Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add kustomize support #536

Closed
askmeegs opened this issue Apr 25, 2021 · 5 comments
Closed

Add kustomize support #536

askmeegs opened this issue Apr 25, 2021 · 5 comments
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. what/feature

Comments

@askmeegs
Copy link
Contributor

Add Kustomize base + overlay structure to replace the following --

  • hack script that produces kubernetes-manifests --> release/kubernetes-manifests workflow (use kustomize to inject image tag + generate manifests)

This will enable teams that need to customize the manifests, allowing them to either contribute their own overlay upstream, or fork the repo + build an overlay there.

@bourgeoisor
Copy link
Member

This is planned and in our roadmap for 2022.

@bourgeoisor
Copy link
Member

This is still planned, but we are looking into Bank of Anthos first. Commenting to reset SLO.

@bourgeoisor
Copy link
Member

@NimJay with https://github.com/GoogleCloudPlatform/microservices-demo/tree/main/kustomize having merged upstream, could you describe what is left to be done for this issue -- for example a list of pending action items?

@NimJay
Copy link
Collaborator

NimJay commented Sep 21, 2022

Thanks for bringing this up, Olivier.
I believe there are a few things we need to do:

  1. Add automation inside of the existing release automation (/hack/make-release-artifacts.sh) to generate the /kustomize/base/ folder. More details can be found in this comment.
  2. Go through the flavours inside docs/ and identify which flavours need to be ported to Kustomize. I believe it's just the following we still need to worry about:
    1. /docs/service-mesh.md
    2. /docs/network-policies/
    3. /docs/workload-identity.md (we'd just be replacing the sed command in step 3)
  3. Create a Kustomize component (inside /kustomize/components/) for each flavour identified in step 2. I've started work on porting over the /docs/network-policies/ flavour in Port NetworkPolicy flavour to Kustomize #1081.

@mathieu-benoit
Copy link
Contributor

Closing this one as Kustomize is now officially documented and supported here: https://github.com/GoogleCloudPlatform/microservices-demo/tree/main/kustomize.

Let's add more variations/overlays by directly opening associated and specific PRs.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. what/feature
Projects
None yet
Development

No branches or pull requests

4 participants