Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Decouple release manifests + standardize release script #549

Closed
wants to merge 6 commits into from

Conversation

askmeegs
Copy link
Contributor

@askmeegs askmeegs commented May 21, 2021

Fixes #375 + is the first step towards kustomize support: #536

Change summary:

  • Decouples release/kubernetes-manifests.yaml into separate files per service. This will support kustomize use cases (patches on individual services) including one I'm about to contribute for non gcp environments (fixing RecommendationService crashes under load-testing - "Request had insufficient authentication scopes." #359)
  • Standardizes the hack release script with what's currently in bank of anthos -- https://github.com/GoogleCloudPlatform/bank-of-anthos/tree/master/release to take dev-kubernetes-manifests/ and write to kubernetes-manifests/.
  • Note - keeping the release manifests in release/ so as to not break existing tutorials. The release pipeline generates both kubernetes manifests (separate files) and release/kubernetes-manifests (1 compiled file)
  • Updates push-and-deploy-latest GH Actions workflow to push the latest images to the google-samples project, not onlineboutique-ci. this way the release and latest images live in the same GCR repo

TODO

  • fix substitute command (s/latest/release-tag)
  • handle the redis exception (do not substitute tag, use redis-alpine for both dev and release)

@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label May 21, 2021
@github-actions
Copy link

🚲 PR staged at http://35.237.255.144

@github-actions
Copy link

🚲 PR staged at http://35.237.255.144

@github-actions
Copy link

🚲 PR staged at http://35.237.255.144

@askmeegs askmeegs added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label May 21, 2021
@askmeegs
Copy link
Contributor Author

askmeegs commented Jun 3, 2021

Closing this in favor of a series of smaller PRs, in line with the kustomize + sample app PRD.

@askmeegs askmeegs closed this Jun 3, 2021
@askmeegs askmeegs deleted the decouple-release-manifests branch December 18, 2021 00:15
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement. do not merge Indicates a pull request not ready for merge, due to either quality or timing.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Decouple release/ Manifests into Separate Files
1 participant