Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

feat: Add generator_args arg to populate --generator-args artman option #224

Merged
merged 3 commits into from
Apr 15, 2019

Conversation

tswast
Copy link
Contributor

@tswast tswast commented Apr 12, 2019

This enables the possibility of sample generation via the --dev_samples
option to the gapic generator. Tested with the Data Catalog Python
client via

library = gapic.py_library(
    "bigquery_datatransfer",
    version,
    config_path="/google/cloud/bigquery/datatransfer/"
    "artman_bigquerydatatransfer.yaml",
    artman_output_name="bigquerydatatransfer-v1",
    include_protos=True,
    generator_args=["--dev_samples"],
)

Closes #223

…option

This enables the possiblity of sample generation via the `--dev_samples`
option to the gapic generator. Tested with the Data Catalog Python
client via

```
library = gapic.py_library(
    "bigquery_datatransfer",
    version,
    config_path="/google/cloud/bigquery/datatransfer/"
    "artman_bigquerydatatransfer.yaml",
    artman_output_name="bigquerydatatransfer-v1",
    include_protos=True,
    generator_args=["--dev_samples"],
)
```
@tswast tswast requested a review from busunkim96 April 12, 2019 20:17
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Apr 12, 2019
@tswast
Copy link
Contributor Author

tswast commented Apr 12, 2019

Tests are passing locally.

==================================================================== 37 passed in 1.67 seconds =====================================================================
nox > Session test was successful.
nox > Running session generate_protos
nox > Creating virtualenv using python3.6 in /Users/swast/src/synthtool/.nox/generate_protos
nox > pip install --upgrade grpcio-tools
nox > python -m grpc_tools.protoc -Isynthtool/protos --python_out=synthtool/protos synthtool/protos/metadata.proto
nox > Session generate_protos was successful.
nox > Ran multiple sessions:
nox > * blacken: success
nox > * lint: success
nox > * test: success
nox > * generate_protos: success

Just pushed a commit for blacken.

@tswast tswast merged commit dd25cdf into googleapis:master Apr 15, 2019
@tswast tswast deleted the issue223-dev_samples branch April 22, 2019 16:48
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Send --dev_samples to Artman via additional arguments to gapic.{lang}_library
3 participants