-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
fix: remove pkg_tar workaround from temurin archive #1582
Conversation
5d4c6c3
to
047dc86
Compare
🌳 🔄 Image Check |
@thesayyn
Current 0755 which looks incorrect to me. Is that just what's provided by the temurin archive? But I can't seem to figure out what's going on here. |
found some other issues here. Duplicate entries of the same file (ex: |
aa64c7a
to
737b1d0
Compare
@loosebazooka okay i fixed the permission issues after a lengthy debug session; rest of the diff is harmless;
|
737b1d0
to
c5d75fa
Compare
I'll check the awk dependency. |
kk awk appears to be on the cloud-build bazel image. So we should be good there. |
this should be ready to land then? |
Removes the workaround for executable files in temurin_archive and replaces it with
tar
from bazel-lib. This PR introduces a new system dependencyawk
for the build. @loosebazooka is awk installed on cloudbuild runners?Some diff is expected, because
tar
rule preserves both numeric and non-numeric owner for files and defaults to file mode on disk.Also bazel-contrib/bazel-lib#829 landed, i will remove genrule once there's a new release of bazel-lib.