-
Notifications
You must be signed in to change notification settings - Fork 1.4k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Feature: debug shell #1727
Closed
Closed
Feature: debug shell #1727
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kvaps
commented
Aug 23, 2021
5941588
to
281915b
Compare
PR rebased to
source code of fork in |
3820876
to
2a4217c
Compare
rebasing with latest master |
Awespme! |
@kvaps would you be able to rebase the PR here? Would like to get this in if possible, thanks! |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds two new options:
--debug
and--debug-shell
which allow to run interactive shell in case of RUN command failed.This option might be very useful during the development the Dockerfile. I'm going to implement it's support into
kubectl-build
plugin.Live demo:
![asciicast](https://camo.githubusercontent.com/72dcbdc2d83e381fa33f1532428b76aedfc6c81b7db33bfe9dda2f69ffee89af/68747470733a2f2f61736369696e656d612e6f72672f612f3433323032302e737667)
Submitter Checklist
These are the criteria that every PR should meet, please check them off as you
review them:
See the contribution guide for more details.
Reviewer Notes
Release Notes
Describe any changes here so maintainer can include it in the release notes, or delete this block.