Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

fix(cmd): fixed err output for delete and deploy commands #9437

Merged
merged 1 commit into from
Jun 10, 2024
Merged

fix(cmd): fixed err output for delete and deploy commands #9437

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion cmd/skaffold/app/cmd/delete.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -55,7 +55,7 @@ func doDelete(ctx context.Context, out io.Writer) error {

manifestListByConfig, err := r.Render(ctx, io.Discard, bRes, false)
if err != nil {
return err
return fmt.Errorf("rendering manifests: %w", err)
}
return r.Cleanup(ctx, out, dryRun, manifestListByConfig, opts.Command)
})
Expand Down
3 changes: 2 additions & 1 deletion cmd/skaffold/app/cmd/deploy.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,6 +18,7 @@ package cmd

import (
"context"
"fmt"
"io"

"github.com/spf13/cobra"
Expand Down Expand Up @@ -54,7 +55,7 @@ func doDeploy(ctx context.Context, out io.Writer) error {
// Render
manifests, errR := r.Render(ctx, out, buildArtifacts, false)
if errR != nil {
return errR
return fmt.Errorf("rendering manifests: %w", errR)
}
return r.DeployAndLog(ctx, out, buildArtifacts, manifests)
})
Expand Down
Loading