-
Notifications
You must be signed in to change notification settings - Fork 72
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Inconsistencies with node core #6
Comments
Thanks @Gozala :) The goal of this module is to match the node/iojs |
@Gozala this can't be reliable achieved without getting back to single module version. I'm fine with this, as in my work I rely more on querystring2 package. If you're also ok with it, in some free moment I can make it so it's single module with latest node.js implementation. |
I just encountered this issue and completely agree with @feross. If you're not going to match the API exactly, at a bare minimum the differences should be documented. As it is today I had to read through the code to see if my implementation was buggy or if this library just didn't support this option. |
@medikoo sure let's merge with your querystring2 if resolves this issue for everyone. |
Any progress on this? |
"add escape/unescape per http://nodejs.org/api/querystring.html, fix for Gozala#6"
Should be addressed with #20 it covers also ES3 version, PR's are very welcome (and I will handle them promptly). |
options
can include adecodeURIComponent
orencodeURIComponent
property. See: https://github.com/joyent/node/blob/master/lib/querystring.js#L180querystring.escape
andquerystring.unescape
, see: http://nodejs.org/api/querystring.html#querystring_querystring_escapeThe text was updated successfully, but these errors were encountered: