Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Update the section about "Embedding Jar Files Inside Your Shadow Jar" #1330

Merged
merged 1 commit into from
Mar 11, 2025

Conversation

Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

The pull request updates the documentation for the shadowJar plugin, specifically focusing on how to embed JAR files inside the shadow JAR. The changes include removing outdated information and providing clearer examples in both Kotlin and Groovy. Overall, the changes improve the clarity and accuracy of the documentation.

Merge Readiness

The changes in this pull request improve the documentation by providing clearer and more accurate instructions on how to embed JAR files using the shadowJar plugin. Since there are no critical, high, or medium severity issues, the pull request is in good shape to be merged. I am unable to approve the pull request, and recommend that others review and approve this code before merging.

@Goooler Goooler requested a review from Copilot March 11, 2025 04:04

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

PR Overview

This PR updates the documentation for embedding jar files inside the shadow jar, providing clearer examples and better guidance for both Kotlin and Groovy users while removing redundant examples.

  • Added detailed Kotlin and Groovy examples for handling jar dependencies with the shadowJar task.
  • Removed outdated extra jar examples to streamline the documentation.

Reviewed Changes

File Description
docs/configuration/dependencies/README.md Updated the "Embedding Jar Files Inside Your Shadow Jar" section with clear Kotlin and Groovy examples.
docs/configuration/README.md Removed the extra jar examples to reduce redundancy.

Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.

@Goooler Goooler enabled auto-merge (squash) March 11, 2025 04:05
@Goooler Goooler merged commit 0ceb3b3 into main Mar 11, 2025
7 checks passed
@Goooler Goooler deleted the g/20250311/update-the-jar-including branch March 11, 2025 04:05
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant