Fix for PropertiesFileTransformer breaks Reproducible builds in 8.1.1 #856 #858
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey @johnrengelman, any chance to have a looks on this? |
https://github.com/codehaus-plexus/plexus-utils#plexus-utils https://github.com/codehaus-plexus/plexus-xml/releases/tag/plexus-xml-4.0.2 --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <wangzongler@gmail.com>
* chore(deps): update dependency gradle to v8.2.1 * Use org.gradle.configuration-cache flag * Update shadow-version.txt * Migrate deprecated ApplicationPluginConvention usages https://docs.gradle.org/8.2.1/javadoc/org/gradle/api/plugins/ApplicationPluginConvention.html * Fix test framework deprecation warning https://docs.gradle.org/8.2.1/userguide/upgrading_version_8.html#test_framework_implementation_dependencies --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <wangzongler@gmail.com>
* chore(deps): update dependency gradle to v8.3 * Impl getPermissions https://docs.gradle.org/8.3/javadoc/org/gradle/api/file/FileTreeElement.html#getPermissions-- * Min Gradle 8.3 * Bump org.gradle.toolchains.foojay-resolver-convention * Migrate deprecated buildDir https://docs.gradle.org/8.3/javadoc/org/gradle/api/Project.html#getBuildDir-- --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <wangzongler@gmail.com>
* chore(deps): update actions/checkout digest to 8ade135 * Update gradle-wrapper-validation.yml --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Goooler <wangzongler@gmail.com>
Co-authored-by: Zongle Wang <wangzongler@gmail.com>
* chore(deps): update gradle/wrapper-validation-action action to v3 * Update gradle-wrapper-validation.yml --------- Co-authored-by: renovate[bot] <29139614+renovate[bot]@users.noreply.github.com> Co-authored-by: Zongle Wang <wangzongler@gmail.com>
https://docs.gradle.com/enterprise/gradle-plugin/legacy/#develocity_migration Co-authored-by: Goooler <wangzongler@gmail.com>
|
Addressed to Goooler#102, this could be closed for now. |
|
Closing due to #876. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Please have a look, added a test (which should fail with 8.1.1) and a fix on CleanProperties.
Removing the timestamp which default Properties class is adding could be tricky. I changed the previous mechanism to be bit more flexible (was not working either as some blank comment line is added now), but either way don't know if is a good approach. Please check