Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Remove expectations from tests #142

Merged

Conversation

NeedleInAJayStack
Copy link
Member

@NeedleInAJayStack NeedleInAJayStack commented Sep 21, 2024

We were getting a few of the following warning in the test code:

warning: 'expectation' mutated after capture by sendable closure

This resolves the warnings by removing unnecessary use of expectation in the unit tests, replacing them with try Future.wait(). I took this opportunity to refactor these tests to simplify them to atomic XCTAssertEquals calls. I also removed the unused allTests extensions.

There were no functional changes to the tests themselves.

@NeedleInAJayStack NeedleInAJayStack merged commit f5a4707 into GraphQLSwift:main Oct 15, 2024
10 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants