Skip to content

Add option to adjust viewport zoom rate in the preferences dialog #2420

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom
Merged
merged 8 commits into from
Apr 8, 2025
Merged

Add option to adjust viewport zoom rate in the preferences dialog #2420

merged 8 commits into from
Apr 8, 2025

Conversation

Sidharth-Singh10
Copy link
Contributor

Closes #2411

@Sidharth-Singh10 Sidharth-Singh10 marked this pull request as ready for review March 14, 2025 15:46
@github-actions GitHub Actions
Copy link

📦 Build Complete for 64c30d2
https://e1bdf74f.graphite.pages.dev

0HyperCube
0HyperCube approved these changes Mar 14, 2025
View reviewed changes
Copy link
Member

@0HyperCube 0HyperCube left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This appears to work nicely; thanks for working on this.

@Keavon
Copy link
Member

Keavon commented Mar 14, 2025 •
edited
Loading

My concern is that the 63 default feels arbitrary. I would prefer a default of 50 and a draggable number input slider between 1 and 100. To be clear though, I'm not talking about changing the rate already present in master. 50 should map to what is currently 63. or to borrow from your comment above:

This PR sets the minimal possible zoom rate to 0.0001 and max possible to 0.05 the default value of 0.005 will correspond to 63 on the frontend

This means whatever is 50, not 63, should become 0.005 and then it should be able to grow by a reasonable amount to reach 100 and shrink by a reasonable amount to reach 1.

@Sidharth-Singh10
Copy link
Contributor Author

Fixed it!

@Keavon
Copy link
Member

Keavon commented Mar 15, 2025

!build

@github-actions GitHub Actions
Copy link

📦 Build Complete for 9d41a45
https://2260030a.graphite.pages.dev

@Sidharth-Singh10 Sidharth-Singh10 requested a review from Keavon March 19, 2025 08:21
@Keavon Keavon force-pushed the master branch 4 times, most recently from aa7ff13 to e11b57a Compare April 6, 2025 11:41
@Keavon
Copy link
Member

Keavon commented Apr 8, 2025

!build

@github-actions GitHub Actions
Copy link

github-actions bot commented Apr 8, 2025

📦 Build Complete for c0bddf4
https://5c5cf64a.graphite.pages.dev

@Keavon Keavon enabled auto-merge (squash) April 8, 2025 07:46
@Keavon Keavon merged commit 3c1ec45 into GraphiteEditor:master Apr 8, 2025
4 checks passed
@Sidharth-Singh10 Sidharth-Singh10 mentioned this pull request Apr 11, 2025
Closed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Keavon Keavon Keavon approved these changes

@0HyperCube 0HyperCube 0HyperCube approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Preference to adjust zoom rate
3 participants
@Sidharth-Singh10 @Keavon @0HyperCube