Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Add php ext sockets #94

Merged
merged 3 commits into from
Jul 1, 2020
Merged

Add php ext sockets #94

merged 3 commits into from
Jul 1, 2020

Conversation

GregoireHebert
Copy link
Owner

Q A
Bug fix? no
New feature? no
BC breaks? no
Deprecations? no
Tests pass? yes
Fixed tickets none
License MIT

Fix the coverage in PHP 7.4

.github/workflows/ci.yml Outdated Show resolved Hide resolved
Copy link
Collaborator

@vincentchalamon vincentchalamon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 if CI is green

@codecov
Copy link

codecov bot commented Jul 1, 2020

Codecov Report

Merging #94 into v5 will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##                 v5      #94   +/-   ##
=========================================
  Coverage     77.42%   77.42%           
  Complexity      229      229           
=========================================
  Files            36       36           
  Lines           988      988           
=========================================
  Hits            765      765           
  Misses          223      223           
Flag Coverage Δ Complexity Δ
#phpunit 77.42% <ø> (ø) 229.00 <ø> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87f1cfb...d57fbf5. Read the comment docs.

@GregoireHebert GregoireHebert merged commit be1ac41 into v5 Jul 1, 2020
@GregoireHebert GregoireHebert deleted the fix-ext-sockets branch July 1, 2020 14:44
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants