Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Fix CUDA 12.0 compilation #1741

Merged
merged 3 commits into from
Feb 15, 2023
Merged

Fix CUDA 12.0 compilation #1741

merged 3 commits into from
Feb 15, 2023

Conversation

havogt
Copy link
Contributor

@havogt havogt commented Feb 9, 2023

nvcc 12.0 crashes in the test_fn_sid_neighbor_table

Additionally: suppress some invalid nvcc warnings

@havogt havogt requested a review from petiaccja February 9, 2023 13:18
MaxNumNeighbors,
sid::ptr_holder_type<Sid>,
sid::strides_type<Sid>>{
origin, strides}; // Note: putting the return type into the function signature will crash nvcc 12.0
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The problem is not visible in CI as we only run some integration tests there for time reasons. The full testsuite is only run on cscs systems, but there we don't have CUDA 12 yet.

@havogt
Copy link
Contributor Author

havogt commented Feb 9, 2023

launch jenkins

@havogt
Copy link
Contributor Author

havogt commented Feb 9, 2023

launch perftests

1 similar comment
@havogt
Copy link
Contributor Author

havogt commented Feb 9, 2023

launch perftests

Copy link
Contributor

@petiaccja petiaccja left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't see anything to address, approved.

@havogt havogt merged commit 6a14f53 into GridTools:master Feb 15, 2023
@havogt havogt deleted the fix_cuda12 branch February 15, 2023 07:47
havogt added a commit that referenced this pull request Feb 15, 2023
nvcc 12.0 crashes in the test_fn_sid_neighbor_table

Additionally: suppress some invalid nvcc warnings
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants