Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

feat: Implement none sort #177

Merged
merged 2 commits into from
Sep 15, 2023
Merged

feat: Implement none sort #177

merged 2 commits into from
Sep 15, 2023

Conversation

hyperupcall
Copy link
Contributor

Closes #176

Gudahtt
Gudahtt reviewed Sep 14, 2023
View reviewed changes
Copy link
Owner

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great! Thanks for the contribution. I can merge this once the branch has been updated and the lint errors resolved

@hyperupcall
Copy link
Contributor Author

hyperupcall commented Sep 14, 2023 •
edited
Loading

Thanks for making this! Both yarn run lint:fix and yarn run test now both exit successfully on my computer.

@hyperupcall hyperupcall requested a review from Gudahtt September 14, 2023 23:51
@Gudahtt Gudahtt merged commit 9ce29d4 into Gudahtt:main Sep 15, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@Gudahtt Gudahtt Awaiting requested review from Gudahtt

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[feature request] Implement "skip" sort option
2 participants
@hyperupcall @Gudahtt