-
-
Notifications
You must be signed in to change notification settings - Fork 570
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Reduce usage of String
in translations code.
#524
Reduce usage of String
in translations code.
#524
Conversation
Thanks! While you are at it, would you mind updating all the translations methods to return an I think there are some cases where I actually don't need them to be strings, so this should be more efficient. In cases |
to_string
calls.String
in translations code.
Although there is a mix usage of |
I agree, and I'm fine with this. |
@all-contributors please add @CosminPerRam for code. |
I've put up a pull request to add @CosminPerRam! 🎉 |
This is a part of #523 (the non-lint part of it).
This PR removes an unnecessary
to_string
call on an alreadyString
value and replaces per-item.to_string()
with an entire match block.to_string()
.