You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository was archived by the owner on Apr 18, 2021. It is now read-only.
[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:
Current behavior
findImports is dependency resolver while compile.
Current implementation use node-find-folder for find filepath of target contract.
But, node-find-folder's out often does not behave what we expect.
For example, assume we have follow directory tree
contracts/
MainContract.sol
lib/
Ownable.sol
external_folder/
Ownable.sol
And at MainContract,
import "./libs/Ownable.sol" -> here we might expect Ownable.sol would be at contracts/lib/Ownable.sol
But node-find-folder doesn't ensure that behavior, so that it has a chance to compile unexpected soruce file.
Expected behavior
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
test: refine test
remove compile log
remove warning at test
remove unnecessary test code in deploy-contract.test.js
fix: fix getPrivateKey index checker
docs: update README.md and commands/README-ko.md
ci: fix err state
test: make privateKeyToAddress, filterPrivateKey test not to be errored
fix: #80 adjust findImports (#81)
* fix: #80 findImports bugfix
* style: some code conventions
* fix: fix error message
chore: release vvisp@v0.2.2 and vvisp-utils@v0.1.8
- @haechi-labs/vvisp-utils@0.1.8
- @haechi-labs/vvisp@0.2.2
refactor: ref package
chore: document, version down
# for freeto subscribe to this conversation on GitHub.
Already have an account?
#.
I'm submitting a...
Current behavior
findImports is dependency resolver while compile.
Current implementation use node-find-folder for find filepath of target contract.
But, node-find-folder's out often does not behave what we expect.
For example, assume we have follow directory tree
contracts/
MainContract.sol
lib/
Ownable.sol
external_folder/
Ownable.sol
And at MainContract,
import "./libs/Ownable.sol" -> here we might expect Ownable.sol would be at contracts/lib/Ownable.sol
But node-find-folder doesn't ensure that behavior, so that it has a chance to compile unexpected soruce file.
Expected behavior
Minimal reproduction of the problem with instructions
What is the motivation / use case for changing the behavior?
Environment
The text was updated successfully, but these errors were encountered: