Skip to content
This repository was archived by the owner on Apr 18, 2021. It is now read-only.

unexpected behavior at vvisp-utils/src/compiler.js:findImports #80

Closed
cloudinertia opened this issue Jan 28, 2019 · 0 comments
Closed
Assignees
Labels
bug Something isn't working error handling Improve Error handling utils About vvisp-utils

Comments

@cloudinertia
Copy link
Contributor

I'm submitting a...


[ ] Regression (a behavior that used to work and stopped working in a new release)
[x] Bug report  
[ ] Performance issue
[ ] Feature request
[ ] Documentation issue or request
[ ] Other... Please describe:

Current behavior

findImports is dependency resolver while compile.
Current implementation use node-find-folder for find filepath of target contract.
But, node-find-folder's out often does not behave what we expect.

For example, assume we have follow directory tree

contracts/
MainContract.sol
lib/
Ownable.sol
external_folder/
Ownable.sol
And at MainContract,
import "./libs/Ownable.sol" -> here we might expect Ownable.sol would be at contracts/lib/Ownable.sol

But node-find-folder doesn't ensure that behavior, so that it has a chance to compile unexpected soruce file.

Expected behavior

Minimal reproduction of the problem with instructions

What is the motivation / use case for changing the behavior?

Environment


vvisp version: X.Y.Z


Environment:
- Node version:
- Operating system:

Others:

cloudinertia added a commit that referenced this issue Jan 28, 2019
cloudinertia added a commit that referenced this issue Jan 28, 2019
@JhChoy JhChoy added bug Something isn't working error handling Improve Error handling utils About vvisp-utils labels Jan 28, 2019
@JhChoy JhChoy closed this as completed in 75ed908 Feb 4, 2019
Nipol pushed a commit that referenced this issue Feb 18, 2019
test: refine test

remove compile log
remove warning at test
remove unnecessary test code in deploy-contract.test.js

fix: fix getPrivateKey index checker

docs: update README.md and commands/README-ko.md

ci: fix err state

test: make privateKeyToAddress, filterPrivateKey test not to be errored

fix: #80 adjust findImports (#81)

* fix: #80 findImports bugfix

* style: some code conventions

* fix: fix error message

chore: release vvisp@v0.2.2 and vvisp-utils@v0.1.8

 - @haechi-labs/vvisp-utils@0.1.8
 - @haechi-labs/vvisp@0.2.2

refactor: ref package

chore: document, version down
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
bug Something isn't working error handling Improve Error handling utils About vvisp-utils
Projects
None yet
Development

No branches or pull requests

2 participants