Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Switch from Associations to Links #115

Merged
merged 2 commits into from
Oct 2, 2024
Merged

Conversation

tmadlener
Copy link
Contributor

Switch happened in key4hep/EDM4hep#341 and without this. Things will start failing once key4hep/EDM4hep#373 is merged.

@BrieucF
Copy link
Contributor

BrieucF commented Oct 2, 2024

Thanks Thomas!

Shall we do the same as here: https://github.com/key4hep/key4hep-dev-utils/pull/9/files ?

@giovannimarchiori
Copy link
Contributor

Indeed in my local version of k4RecCalorimeter I added
+# ignore false positive no-dangling-reference warnings from GNU gcc
+if(CMAKE_CXX_COMPILER_ID STREQUAL "GNU")

  • set(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-dangling-reference")
    +endif()

to CMakeLists.txt to get rid of those annoying false positive from gcc 14..

@tmadlener
Copy link
Contributor Author

I made a second PR to fix that to not mix things in the git history.

@kjvbrt kjvbrt merged commit 7ddab6a into HEP-FCC:main Oct 2, 2024
2 of 5 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants