Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

[Fix] Replace finally statement by except BaseException to suppress all exceptions #653

Merged
merged 1 commit into from
Jan 6, 2025
Merged

[Fix] Replace finally statement by except BaseException to suppress all exceptions #653

merged 1 commit into from
Jan 6, 2025

Conversation

fjosw
Copy link
Collaborator

@fjosw fjosw commented Nov 3, 2024

Closes #651

@fjosw fjosw force-pushed the fix/wrap_exceptions branch from 9824dc7 to 7425126 Compare November 3, 2024 17:11
@fjosw @iritkatriel
[Fix] Replace finally statement by except BaseException to suppress all
32260b5 
exceptions

Co-authored-by:  Irit Katriel <iritkatriel@users.noreply.github.com>
@fjosw fjosw force-pushed the fix/wrap_exceptions branch from 7425126 to 32260b5 Compare November 3, 2024 17:11
@fjosw fjosw mentioned this pull request Nov 3, 2024
Closed
agriyakhetarpal
agriyakhetarpal approved these changes Nov 25, 2024
View reviewed changes
Copy link
Collaborator

@agriyakhetarpal agriyakhetarpal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fjosw, I read through #651 and I think this is alright – please feel free to merge! Though, I also feel that this code wasn't written very well in the first place ;)

@agriyakhetarpal
Copy link
Collaborator

Let's merge this for now :D

@agriyakhetarpal agriyakhetarpal merged commit ce202b9 into HIPS:master Jan 6, 2025
30 checks passed
# for free to join this conversation on GitHub. Already have an account? # to comment
Reviewers

@agriyakhetarpal agriyakhetarpal agriyakhetarpal approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

return in finally swallows exceptions
2 participants
@fjosw @agriyakhetarpal