[ISSUE alibaba#12282]Fix the issue where monitoring data cannot be fo…

…und through the IP dimension in the ListeningQuery
HMYDK · Jun 26, 2024 · adfed72 · adfed72
1 parent b8a60f2
commit adfed72
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 3 deletions.
diff --git a/config/src/main/java/com/alibaba/nacos/config/server/controller/CommunicationController.java b/config/src/main/java/com/alibaba/nacos/config/server/controller/CommunicationController.java
@@ -139,7 +139,7 @@ private SampleResult searchByIp(String ip) {
      * @return SampleResult
      */
     @GetMapping("/config")
-    public SampleResult getSubClientConfig(
+    public SampleResult getSubClientConfigV2(
             @RequestParam("type") String type,
             @RequestParam(value = "ip", required = false) String ip,
             @RequestParam(value = "dataId", required = false) String dataId,

diff --git a/config/src/main/java/com/alibaba/nacos/config/server/enums/ConfigSearchRequestTypeEnum.java b/config/src/main/java/com/alibaba/nacos/config/server/enums/ConfigSearchRequestTypeEnum.java
@@ -1,7 +1,7 @@
 package com.alibaba.nacos.config.server.enums;
 
 /**
- * ConfigSearchRequestTypeEnum
+ * Config search request type enum.
  *
  * @author hmydk
  */
@@ -17,6 +17,11 @@ public enum ConfigSearchRequestTypeEnum {
         this.type = type;
     }
 
+    /**
+     * check type is legal.
+     * @param type type
+     * @return true or false
+     */
     public static boolean checkTypeLegal(String type) {
         for (ConfigSearchRequestTypeEnum configSearchRequestTypeEnum : ConfigSearchRequestTypeEnum.values()) {
             if (configSearchRequestTypeEnum.getType().equals(type)) {

diff --git a/...src/test/java/com/alibaba/nacos/config/server/controller/CommunicationControllerTest.java b/...src/test/java/com/alibaba/nacos/config/server/controller/CommunicationControllerTest.java
@@ -152,7 +152,6 @@ void testGetSubClientConfigByIp() throws Exception {
 
     }
 
-
     @Test
     void testGetSubClientConfigV21x() throws Exception {
Original file line number	Diff line number	Diff line change
Expand Up		@@ -152,7 +152,6 @@ void testGetSubClientConfigByIp() throws Exception {

		}


		@Test
		void testGetSubClientConfigV21x() throws Exception {

Expand Down