Bump Node from v18 to v20 #5005
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
node18-alpine3.18 is required, to avoid node-gyp errors, see nodejs/docker-node#2009
A couple of webpack plugins (e.g.ComressionPlugin) use hardcode md4 for hash generation, which is not supported by OpenSSL3.0 anymore. Until they are configurable we fall back to openssl-legacy-provider. See https://stackoverflow.com/questions/69394632/webpack-build-failing-with-err-ossl-evp-unsupported
bumping the resolution for sharp to 0.33 removes the need to pin alpine 3.18. (See nodejs/docker-node#2009) Without resolution, sharp is fixed to 0.28.3 which clashes with the libvips for newer alpines.
|
Thanks for a valuable contribution! Everything seems to work very well. I believe we will merge this PR right after our next production release 3rd June. |
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative PR for #5003 to update node even further to currently active v20, which, as even numbered version will be LTS and maintained until spring 2026.
Proposed Changes
node20:alpinewhich currently is based on alpine 3.19 and otherwise would result into compilation issues, see Latest docker build breaks node-gyp in node-18 nodejs/docker-node#2009).Pull Request Check List
A reasonable set of unit tests is includedReview