Support qwenvl model for HPU #793
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yingjie-han
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
|
@michalkuligowski @jikunshang @PatrykWo could you help to review the code? |
michalkuligowski
requested changes
Feb 26, 2025
vllm/model_executor/models/qwen.py
Outdated
| inputs_embeds = merge_multimodal_embeddings( | ||
| input_ids, inputs_embeds, multimodal_embeddings, | ||
| self.transformer.visual.image_pad_id) | ||
| batch_size, seq_length, hidden_size = inputs_embeds.shape |
There was a problem hiding this comment.
@michalkuligowski Merge conflicts has been solved. Please review it. Thanks
yingjie-han
force-pushed
the
yingjie/qwenvl
branch
from
834ee00 to
705cc8f
Compare
michalkuligowski
requested changes
Mar 6, 2025
| inputs_embeds = merge_multimodal_embeddings( | ||
| input_ids, inputs_embeds, multimodal_embeddings, | ||
| self.transformer.visual.image_pad_id) | ||
| batch_size, seq_length, hidden_size = inputs_embeds.shape |
There was a problem hiding this comment.
This shouldnt be in model definition. Please try fixing the merge_multimodal_embeddings method. You can check whether its hpu to call your implementation
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to support qwenvl vision infer on HPU.
Issue to solve
The function merge_multimodal_embeddings() in utils.py has dynamic problem on HPU.
Solution
Flatten the embeddings tensor , and use index_put_() to merge the multimodal embeddings in qwen.py instead of calling merge_multimodal_embeddings() in utils.py.
Test
Single image
python examples/offline_inference/vision_language.py -m qwen_vlMultiple images
python examples/offline_inference/vision_language_multi_image.py -m qwen_vl_chat