enable LoRA for embedding models #821
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…such as bert,roberta, bart.
….inf caused nan for softmax calculation.
…ith vllm-hpu-extension change
skaulintel
requested review from
kzawora-intel,
madamczykhabana,
michalkuligowski,
mgawarkiewicz,
vivekgoe and
afierka-intel
as code owners
|
@skaulintel fix the pre-commit issue: https://github.com/HabanaAI/vllm-fork/actions/runs/13419658543/job/37488981187?pr=821 please. Then rebase on habana-main to fix two fails in jenkins test. Can you also explain, link changes in requirements-hpu? Why actually you change hash of vllm-hpu-extension? Is is neccessary or is it a development artifact? Thank you! |
michalkuligowski
requested changes
Feb 27, 2025
| @@ -1588,6 +1588,76 @@ def prepare_input_tensors( | |||
| lora_ids=lora_ids), \ | |||
| sampling_metadata | |||
|
|
|||
| def create_lora_mask(self, input_tokens: torch.Tensor, lora_ids: List[int], | |||
There was a problem hiding this comment.
There are still yapf errors in precommit, please fix
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
enable lora for text embedding models. Depends on 758
tested for