Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Expression Language support #1654

Open
wants to merge 20 commits into
base: master
Choose a base branch
from

Conversation

adamwojs
Copy link
Contributor

@adamwojs adamwojs commented Jun 3, 2021

Added support for Expression Language component (https://symfony.com/doc/current/components/expression_language.html)

TODO

  • Impl. Parser
  • Impl. Syntax Highlighter
  • Impl. Syntax Highlighter settings
  • Impl. Brace Matcher
  • Impl. Quote Handler

Auto inject expression language into:

Note for reviewers

Expression Language parser

Language Injections

  • Deprecated fr.adrienbrault.idea.symfony2plugin.lang.ParameterLanguageInjector in favour of fr.adrienbrault.idea.symfony2plugin.lang.StringLiteralLanguageInjector
  • In compare to previous impl. StringLiteralLanguageInjector allows inject language into string literals used in various contexts: Attributes, Annotations, Constructor/Function/Method call argument, Variable assigment and also takes into account named arguments introduced in PHP 8
  • Expression Language is injected into YAML/XML files by YamlLanguageInjector / XmlLanguageInjector

Links

@adamwojs adamwojs force-pushed the expression_lang_support branch from 2aea320 to 2e248f5 Compare June 3, 2021 17:22
@King2500
Copy link
Contributor

King2500 commented Jun 3, 2021

I had the same idea in mind a while ago. But since it's time consuming i didn't start working on it.

Sounds good! 👍

Is it possible to (auto-)inject it inside DocTags and/or PHP8 attributes?

@adamwojs
Copy link
Contributor Author

adamwojs commented Jun 4, 2021

Thank you for feedback @King2500!

Is it possible to (auto-)inject it inside DocTags and/or PHP8 attributes?

Yes, I think it's possible. I will go through symfony documentation and try identify all possible spots before moving PR from draft to "Ready for review" state.

@adamwojs adamwojs force-pushed the expression_lang_support branch 2 times, most recently from efc97a8 to 16bbbdd Compare June 5, 2021 12:27
@adamwojs adamwojs force-pushed the expression_lang_support branch 6 times, most recently from 78b7cd8 to 3aa43aa Compare June 26, 2021 09:18
@adamwojs adamwojs force-pushed the expression_lang_support branch 2 times, most recently from 774e536 to 1347346 Compare July 3, 2021 12:19
@adamwojs adamwojs marked this pull request as ready for review July 3, 2021 19:32
@adamwojs adamwojs force-pushed the expression_lang_support branch 2 times, most recently from 5cc0e30 to 6133ea9 Compare July 8, 2021 19:52
@adamwojs adamwojs force-pushed the expression_lang_support branch from 98daa78 to 5464605 Compare July 18, 2021 19:27
@adamwojs adamwojs force-pushed the expression_lang_support branch from 5464605 to 14afd15 Compare September 18, 2021 10:27
@adamwojs adamwojs force-pushed the expression_lang_support branch from 44eba02 to e5b4001 Compare May 22, 2022 09:27
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants