Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Removed deprecated features from SRT C API #1364

Merged
merged 8 commits into from
Jun 26, 2020

Conversation

ethouris
Copy link
Collaborator

@ethouris ethouris commented Jun 22, 2020

Fixes #994

@ethouris ethouris requested a review from maxsharabayko June 22, 2020 15:09
@ethouris ethouris self-assigned this Jun 22, 2020
@ethouris ethouris added [apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Impact: Significant Priority: High Type: Maintenance Work required to maintain or clean up the code labels Jun 22, 2020
@ethouris ethouris marked this pull request as draft June 22, 2020 15:10
@ethouris ethouris marked this pull request as ready for review June 24, 2020 14:04
@maxsharabayko maxsharabayko merged commit 0e2201a into Haivision:master Jun 26, 2020
@@ -11796,7 +11795,7 @@ static bool getOptDefault(SRT_SOCKOPT optname, void* pw_optval, int& w_optlen)

case SRTO_SENDER: RD(false);
case SRTO_TSBPDMODE: RD(false);
case SRTO_TSBPDDELAY:
case SRTO_LATENCY:
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Renaming this breaks building vlc against srt 1.4.2.

A more specific commit message in regards to this change and why it was changed would have been nice and helpful

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
[apps] Area: Test applications related improvements [core] Area: Changes in SRT library core Priority: High Type: Maintenance Work required to maintain or clean up the code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Delete deprecated socket options
3 participants