Merge pull request plotly#170 from plotly/mdn-update-yari

Update component generation
HammadTheOne · Dec 15, 2020 · d0dafd3 · d0dafd3
1 parent 1b78f59
commit d0dafd3
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 1 deletion.
diff --git a/packages/dash-html-components/scripts/extract-attributes.js b/packages/dash-html-components/scripts/extract-attributes.js
@@ -55,7 +55,10 @@ const attributeMap = supportedAttributes.reduce((map, reactAttribute) => {
  * descriptions and supported elements.
  */
 function extractAttributes($) {
-    const $table = $('#Attribute_list').next('table');
+    const $table = $('#Attribute_list').parent().find('table');
+    if($table.length !== 1) {
+        throw new Error('page structure changed at ' + htmlURL);
+    }
     const attributes = {};
 
     $table.find('tbody tr').each((i, row) => {

diff --git a/packages/dash-html-components/scripts/generate-components.js b/packages/dash-html-components/scripts/generate-components.js
@@ -192,6 +192,9 @@ function generatePropTypes(element, attributes) {
         component_name: PropTypes.string,
     }),
 
+    /**
+     * Dash-assigned callback that gets fired when the element is clicked.
+     */
     'setProps': PropTypes.func`
 }
-Original file line number
+Diff line change
@@ Expand Up / @@ -192,6 +192,9 @@ function generatePropTypes(element, attributes) { @@
             component_name: PropTypes.string,
         }),
+        /**
+         * Dash-assigned callback that gets fired when the element is clicked.
+         */
         'setProps': PropTypes.func`
     }
@@ Expand Down @@