Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

hs.urlevent callback parameters are now lowercase #3691

Merged
merged 1 commit into from
Nov 9, 2024
Merged

hs.urlevent callback parameters are now lowercase #3691

merged 1 commit into from
Nov 9, 2024

Conversation

cmsj
Copy link
Member

@cmsj cmsj commented Sep 19, 2024

Closes #3686

@cmsj cmsj added the pr-fix Pull Request implementing a bug fix label Sep 19, 2024
@cmsj cmsj self-assigned this Sep 19, 2024
@cmsj cmsj added this to the 1.0.1 milestone Sep 19, 2024
Copy link

codecov bot commented Sep 19, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 5.98%. Comparing base (d0c7fcf) to head (9cc80bd).
Report is 1 commits behind head on master.

Additional details and impacted files
@@          Coverage Diff           @@
##           master   #3691   +/-   ##
======================================
  Coverage    5.98%   5.98%           
======================================
  Files         191     191           
  Lines       51381   51381           
======================================
  Hits         3077    3077           
  Misses      48304   48304           

@cmsj cmsj merged commit 5395f34 into master Nov 9, 2024
1 of 2 checks passed
@cmsj cmsj deleted the fix-3686 branch November 9, 2024 13:55
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
pr-fix Pull Request implementing a bug fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

hs.urlevent incorrectly treats scheme in case sensitive manner
1 participant