Add mention of available Ubuntu and Arch Linux packages + add BUILD_TESTING to the list of CMake options #221
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Please see comments inline |
HappySeaFox
reviewed
Dec 29, 2024
HappySeaFox
reviewed
Dec 29, 2024
|
|
||
| - Ubuntu 24.04 - `sudo apt-get install sail-codecs libsail-dev libsail-common-dev libsail-manip-dev libsail-c++-dev` | ||
| - Arch User Repository - [`sail-img`](https://aur.archlinux.org/packages/sail-img) | ||
|
|
There was a problem hiding this comment.
Debian packages are also available: https://packages.debian.org/search?keywords=libsail
HappySeaFox
reviewed
Dec 29, 2024
| @@ -27,6 +27,8 @@ vcpkg install sail | |||
| - `SAIL_ONLY_CODECS="a;b;c"` - Forcefully enable only the codecs specified in this ';'-separated list and disable the rest. If an enabled codec fails to find its dependencies, the configuration process fails. One can also specify not just individual codecs but codec groups by their priority like that: highest-priority;xbm. Default: empty list | |||
| - `SAIL_OPENMP_SCHEDULE="dynamic"` - OpenMP scheduling algorithm. Default: dynamic | |||
|
|
|||
| - `BUILD_TESTING=ON|OFF` - Enable generation of tests using CTest. Default: `ON` | |||
There was a problem hiding this comment.
Keep the list of the options sorted, i.e. move the BUILD_TESTING option to keep the list sorted
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, today I was updating the AUR package and I noticed that tests were always being built and there is no option to disable them. I have never used CTest so when I looked at the root CMakeLists.txt file, i thought there was a mistake and I wanted to add something like a
SAIL_BUILD_TESTSoption. Thankfully I checked closed PRs and saw a pull request that tried to do the same thing.I know that the option is probably not listed in the CMake options overview in
BUILDING.md, because it's a built-in CMake option and not specific to this project, however I still think it's worth mentioning.I also listed available Ubuntu and AUR packages of this project. I also checked Debian, Fedora and NixOS repositories, but could not find any related packages there.