Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Tweaks to warp point #666

Merged
merged 2 commits into from
Jun 25, 2024

Conversation

garrettjoecox
Copy link
Contributor

@garrettjoecox garrettjoecox commented Jun 5, 2024

Summary:

  • Fix issue where some flags from current scene would be applied to target scene when warping
  • Increased speed of warp
  • Introduce hidden cvar for dev use only to boot into the warp point (very very very nice)
    • This is hidden because I'm not 100% confident it sets everything up correctly. Works in my testing
    • This is incompatible with SkipToFileSelect
  • Hookify SkipToFileSelect

Build Artifacts

Copy link
Contributor

@Archez Archez left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good! Having gGameState is going to be interesting, and should make things like resetting the game outside of a "playstate" possible!

I've included a small suggestion to preserve the "Skip to File select" enhancement waiting for the console logo to fade out like it did before.

mm/2s2h/Enhancements/Cutscenes/SkipToFileSelect.cpp Outdated Show resolved Hide resolved
@Archez Archez merged commit 2e4710c into HarbourMasters:develop Jun 25, 2024
5 checks passed
mckinlee pushed a commit to mckinlee/2ship2harkinian that referenced this pull request Oct 4, 2024
* Tweaks to warp point

* wait for console logo exit

---------

Co-authored-by: Archez <Archez@users.noreply.github.com>
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants