Fix: Prevent Dawn Of screen crashing with 4th day glitch #718
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The "Dawn Of" screen would crash with the 4th day glitch due to an OOB read for the textures with the hours remaining text. Adding another entry at the end of this array with our empty texture fix prevents the crash and replicates console behavior of nothing rendering there.
This happens because the
CURRENT_DAYmacro mods the day value with5and then in the Dawn Of screen, the macro value is subtracted by1. So a value of3is used to index all the texture arrays. The Dawn Of arrays already have a 4th entry for the "New Day" textures.Because the 4th day glitch always repeats the 4th day and doesn't increment the day value means we don't have to worry about an index of
4going into these arrays.Build Artifacts