Tweak FreeLook camera reset logic #721
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
inspectredc
approved these changes
Jun 26, 2024
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The FreeLook camera was resetting when performing simple actions like attacking with a sword. The camera mode check had some confusing and overlapping range checks, so I've switched to using a switch with explicit cases for the camera modes we want to clear (essentially any Z targeting, aiming, firstperson, and boomerang modes).
I also moved the cutscene check to
CanFreeLookso that we check on all frames for cutscene mode, instead of just when the camera mode changes. This addresses the strange camera position issue when moving the camera through a transition while riding Epona.Fixes #508
Build Artifacts