CVE-2024-22857: buffer overflow patched #251
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Size of
record_nameisMAXLEN_PATH(1024) + 1butfile_pathmay have data uptoMAXLEN_CFG_LINE(MAXLEN_PATH*4) + 1. So a check was missing inzlog_rule_new()while copying therecord_namefromfile_path + 1which caused the buffer overflow. An attacker can exploit this vulnerability to overwrite thezlog_record_fn record_funcfunction pointer to get arbitrary code execution.