Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[cppia] Generate scriptable functions for overriden functions #11773

Merged
merged 1 commit into from
Sep 17, 2024

Conversation

Aidan63
Copy link
Contributor

@Aidan63 Aidan63 commented Sep 15, 2024

Fixes HaxeFoundation/hxcpp#1150

Test has been added in this hxcpp merge HaxeFoundation/hxcpp#1154

That hxcpp merge is failing due to the new test, once this is merged the CI on that hxcpp merge should be re-ran and it will then pass.

@Simn
Copy link
Member

Simn commented Sep 16, 2024

Does this interact with overloads somehow given that we're comparing methods by name?

@Aidan63
Copy link
Contributor Author

Aidan63 commented Sep 16, 2024

I don't think so. Overloads only really work on extern classes iirc, and that code is only ran on haxe classes and interfaces.

@Simn Simn merged commit b99eda0 into HaxeFoundation:development Sep 17, 2024
50 checks passed
@skial skial mentioned this pull request Sep 17, 2024
1 task
@Aidan63 Aidan63 deleted the cppia-overloads branch September 17, 2024 17:01
@rainyt
Copy link

rainyt commented Jan 18, 2025

This fix doesn't seem to have released a new haxe yet. Can I get a new haxe executable file from the nightly build? Which one is stable? (Mac user)

@rainyt
Copy link

rainyt commented Jan 18, 2025

4.3 bug fix did not update this modification. Can it be fixed in 4.3?

@kLabz kLabz added this to the 4.3 Hotfix candidates milestone Jan 18, 2025
@rainyt
Copy link

rainyt commented Jan 19, 2025

src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp 
Error: ./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:141:13: error: invalid covariant return type for 'virtual Dynamic haxe::ds::_GenericStack::GenericStackIterator_hscript_Token_obj__scriptable::next()'
   ::Dynamic next(  ) {
             ^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:48:19: error:   overriding 'virtual hscript::Token haxe::ds::_GenericStack::GenericStackIterator_hscript_Token_obj::next()'
  ::hscript::Token GenericStackIterator_hscript_Token_obj::next(){
                   ^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:152:55: warning: 'fastcall' attribute directive ignored [-Wattributes]
 static void CPPIA_CALL __s_hasNext(::hx::CppiaCtx *ctx) {
                                                       ^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:157:52: warning: 'fastcall' attribute directive ignored [-Wattributes]
 static void CPPIA_CALL __s_next(::hx::CppiaCtx *ctx) {
                                                    ^
./src/haxe/ds/_GenericStack/GenericStackIterator_hscript_Token.cpp:171:67: warning: 'fastcall' attribute directive ignored [-Wattributes]
 static void CPPIA_CALL __script_construct_func(::hx::CppiaCtx *ctx) {

I have tried this fix, but compilation errors occur.

@rainyt
Copy link

rainyt commented Jan 20, 2025

HaxeFoundation/hxcpp#1175

Even with this PR, the test cases cannot pass. This is my issues.

# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[cppia] Cant seem to get host to call extern super functions
4 participants