Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

[Feature request] add a add_header function or an add option #204

Open
lublak opened this issue Dec 17, 2019 · 0 comments
Open

[Feature request] add a add_header function or an add option #204

lublak opened this issue Dec 17, 2019 · 0 comments

Comments

@lublak
Copy link

lublak commented Dec 17, 2019

If i look right we can just copy set_header to add_header and ap_table_set to replace ap_table_add
https://github.com/HaxeFoundation/neko/blob/master/libs/mod_neko/cgi.c#L178

Or we can add an option as bool add like in https://github.com/HaxeFoundation/neko/blob/master/libs/mod_tora/mod_tora.c#L132

I think it's better to add a new function so as not to break any code.

If it is added should we also add this function to: https://github.com/HaxeFoundation/haxe/blob/development/std/neko/Web.hx#L108

Also we can add it to php https://github.com/HaxeFoundation/haxe/blob/development/std/php/Web.hx#L129 with header('$h: $v', false);

I am currently trying to find out how Tora is affected.

lublak added a commit to lublak/neko that referenced this issue Dec 22, 2019
lublak added a commit to lublak/tora that referenced this issue Dec 24, 2019
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant