Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Dean/plotly #321

Merged
merged 21 commits into from
Apr 13, 2023
Merged

Dean/plotly #321

merged 21 commits into from
Apr 13, 2023

Conversation

dastratakos
Copy link
Collaborator

This PR adds all of the plotly.express components as built-in meerkat components. Each component exposes a few key plotly args for auto-complete and then forwards the rest of the args through **kwargs. Additionally, they all have the on_click and on_select Endpoints that allow for meerkat interactivity. The main idea is that a plotly express component is created on the Python side and then passed to the Svelte frontend in JSON form using fig.to_json().

In the dev repo, I tested on_click and on_select for the first 10 components alphabetically and noticed that DensityContour and DensityHeatmap might need a little more work since the clicking and selecting isn't exactly intuitive.

@seyuboglu
Copy link
Collaborator

Looks like its failing some of the linting. Try running make lint locally and address the issues (looks like its mostly lines too long)

@seyuboglu
Copy link
Collaborator

Otherwise looking great

@dastratakos
Copy link
Collaborator Author

Thanks for pointing that out. Should be fixed now

@seyuboglu
Copy link
Collaborator

I think the failing test was just a missing entry in index.js. Added it here 1e6cfa4

@codecov-commenter
Copy link

codecov-commenter commented Apr 13, 2023

Codecov Report

Merging #321 (1e6cfa4) into main (86dfb17) will increase coverage by 0.22%.
The diff coverage is 75.80%.

@@            Coverage Diff             @@
##             main     #321      +/-   ##
==========================================
+ Coverage   67.38%   67.61%   +0.22%     
==========================================
  Files         211      244      +33     
  Lines       11943    13045    +1102     
  Branches     1787     1885      +98     
==========================================
+ Hits         8048     8820     +772     
- Misses       3469     3799     +330     
  Partials      426      426              
Flag Coverage Δ
unittests 67.61% <75.80%> (+0.22%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Impacted Files Coverage Δ
...e/app/src/lib/component/plotly/scatter/__init__.py 75.00% <66.66%> (-15.48%) ⬇️
...tive/app/src/lib/component/plotly/area/__init__.py 75.00% <75.00%> (ø)
...app/src/lib/component/plotly/bar_polar/__init__.py 75.00% <75.00%> (ø)
...ctive/app/src/lib/component/plotly/box/__init__.py 75.00% <75.00%> (ø)
...pp/src/lib/component/plotly/choropleth/__init__.py 75.00% <75.00%> (ø)
...lib/component/plotly/choropleth_mapbox/__init__.py 75.00% <75.00%> (ø)
...c/lib/component/plotly/density_contour/__init__.py 75.00% <75.00%> (ø)
...c/lib/component/plotly/density_heatmap/__init__.py 75.00% <75.00%> (ø)
...rc/lib/component/plotly/density_mapbox/__init__.py 75.00% <75.00%> (ø)
...tive/app/src/lib/component/plotly/ecdf/__init__.py 75.00% <75.00%> (ø)
... and 26 more

... and 8 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@seyuboglu seyuboglu merged commit ead6eb1 into main Apr 13, 2023
# for free to join this conversation on GitHub. Already have an account? # to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants