-
Notifications
You must be signed in to change notification settings - Fork 43
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Dean/plotly #321
Dean/plotly #321
Conversation
Looks like its failing some of the linting. Try running |
Otherwise looking great |
Thanks for pointing that out. Should be fixed now |
I think the failing test was just a missing entry in index.js. Added it here 1e6cfa4 |
Codecov Report
@@ Coverage Diff @@
## main #321 +/- ##
==========================================
+ Coverage 67.38% 67.61% +0.22%
==========================================
Files 211 244 +33
Lines 11943 13045 +1102
Branches 1787 1885 +98
==========================================
+ Hits 8048 8820 +772
- Misses 3469 3799 +330
Partials 426 426
Flags with carried forward coverage won't be shown. Click here to find out more.
... and 8 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
This PR adds all of the
plotly.express
components as built-in meerkat components. Each component exposes a few key plotly args for auto-complete and then forwards the rest of the args through**kwargs
. Additionally, they all have theon_click
andon_select
Endpoints that allow for meerkat interactivity. The main idea is that a plotly express component is created on the Python side and then passed to the Svelte frontend in JSON form usingfig.to_json()
.In the dev repo, I tested
on_click
andon_select
for the first 10 components alphabetically and noticed thatDensityContour
andDensityHeatmap
might need a little more work since the clicking and selecting isn't exactly intuitive.