Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

spat.py likely to be too strict about matching filenames #45

Closed
Jellix opened this issue Jun 25, 2020 · 0 comments · Fixed by #46
Closed

spat.py likely to be too strict about matching filenames #45

Jellix opened this issue Jun 25, 2020 · 0 comments · Fixed by #46
Assignees
@Jellix
Labels
bug Something isn't working
Milestone
V1.1.0

Comments

@Jellix
Copy link
Member

Jellix commented Jun 25, 2020 •
edited
Loading

Describe the bug
The regular expression for a file:line:column "([a-z0-9-]+\.ad[bs]):(\d+):(\d+)" only works if the standard GNAT convention is used, as soon as there are upper case letters, it won't match, so spat.py will not show anything.

Also, the original expression totally missed that we could have underscores in file names.
@Jellix Jellix added the bug Something isn't working label Jun 25, 2020
@Jellix Jellix added this to the V1.1.0 milestone Jun 25, 2020
@Jellix Jellix self-assigned this Jun 25, 2020
This was referenced Jun 25, 2020
Merged
Merged
Jellix added a commit that referenced this issue Jun 25, 2020
@Jellix
Relaxed file name pattern (#46)
4e92082 
Fixes issue #45
@Jellix Jellix linked a pull request Jun 25, 2020 that will close this issue
Relaxed file name pattern #46
Merged
@Jellix Jellix closed this as completed Jun 25, 2020
# for free to join this conversation on GitHub. Already have an account? # to comment
Assignees

@Jellix Jellix

Labels
bug Something isn't working
Projects
None yet
Milestone
V1.1.0
Development

Successfully merging a pull request may close this issue.

Relaxed file name pattern HeisenbugLtd/spat
1 participant
@Jellix