-
-
Notifications
You must be signed in to change notification settings - Fork 112
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Rework of UK and RU standard layout plus added extended layout (similar to PC keyboard) as optional #1215
base: main
Are you sure you want to change the base?
Conversation
…ar to PC keyboard) as optional; Rework standard UK and RU keyboards: UA) - Added 'ї' as separate letter (it used much more often, just to be optional key in popups) - Added [ { } } popups to fill empty hint space (similar to PC layout) - Added ' (apostrofee) suggestion onto 'є' key (similar to oter keyboards and to PC layout) RU) Added siggestion to 'ъ' on 'х' key (similar to other keyboards, anyway there was no popups at all) - Added [ { } } popups to fill empty hint space (similar to PC layout) - Added 'э́' suggestion similar to other keyboards Both) - Improvements to multilanguage typing (now this is possible to sue UK-RU or RU-UK pair, I added letters from other language as popups) Added) - UK Extended with separate ' key (used less often than 'ї', but still used pretty often) - RU Extended, with separate 'ъ' key (similar to full desk PC layout) (Maybe i forgot something)
Thank you very much for providing a detailed explanation and reasoning of your PR!
Here I'm not convinced. Enabling multilingual typing already combines I see you have |
First and maybe temporary fix for multilanguage hints for not show them if you dont use multilanguage
Made a bunch of test builds and expiriments, and because my prewious almost written detailed message was lost, i will write all shorter, sorry.
I may suggest re-add old UK layout re-using existing class of
After i test it i had an idea, tryed, and this worked. I simply added additional keys to RU letters into UK locale texts (e.g 'ы і ї', letter 'ы' don't exist in UK, so if multitype don't enabled it doesen't show up everywhere. But when you combine them, locale texts combines and boom - RU than show you wanted 'ы і ї', witch stored in UK locale texts! So no one will be harmed - those who dont want dont see them, and those who want multilanguage will see them. P.S. this appears to me only as a temporary solution, i can think of separate set of locale texts that will be applyed ONLY if selected multilanguage typing, something that can be called like 'ru-UK' (where all lowercase indicate that this is two LANGUAGES, when 'uk_UK' indicate (now) separate LAYOUT). What you think about this?
I don't found any documentation about more popups, and no any buttons that allow me use that. BTW that not so much problem, the proplem is that I want include special hints that use DIFERENT sounds/charctaers, not a variations, but different. For example, i wanna place Any further suggestions if welcome off course) P.P.S. I upload updated version of my changes into my git fork, you can see how i made changes to locale texts, i added new row only for be used in multitype, e.g:
|
Sorry to hear that, such loss of written text can be very annoying. There are some browser addons against this, like https://github.com/wildskyf/TextareaCache and https://stephanmahieu.github.io/fhc-home/.
That's a good point, I'll consider it in case someone doesn't like the separat
It's not a really clean solution, but very simple so I thinks it's ok. And I don't expect it to have negative side effects.
Hmm this doesn't really fit in my opinion, and adds more complexity for dealing with a very special case. From what you write (specific hints in specific places, muscle memory) it seems more like you want some ru/uk layout specialized for multilingual typing? Maybe it would make more sense to add something like that? |
As a native UK and RU speaker and newcomer from other keyboard apps, I found RU and, mostly, UK layouts so much uncomfortable, in comparing to others, so I come and make rework of exiting layouts
I maked this changes:
More detail explanation of all changes are in this commit, or in diff compare below.
The changes are final an fully tested by me localy. Keyboard works properly.
All changes are in way described in this guidelines
Why this changes should be in baze Heliboard
Ukrainan:
As a native speaker, usage of 'ї' when it attached as popup to 'і' are not comfortable, because 'ї' it is not just vatiant of 'і', this is separate letter, with separate sound, and it used quite often. For exmple, our analog to english 'she's' or 'belongs to she' is literaly written as 'її'. Not only one, but two of this letter! And, we use he/she much more common in speaking, than in english, so this are much more suitable and overall just less time consuming when you have separate 'ї' letter, instead of 'hold on 'і', choose 'ї', repeat it again to type 'її'. ' Additionaly, keyboard have space for this – third row are anyway densier that 1 even with additional 'ї' key. And lastly, all other keyboards on market added 'ї' as separate letter long time ago with no problem and this make life only easier to native ukrainian speakers.
Additionaly, I had provided old popup with 'ї' to'і', for making change less problematic, but it have problems described there
Ukrainian and Russian both:
The additional locale_key_texts for both languages just overall make typing more flexible and allow proper usage of multilanguage typing now. There no harm in this, only benefits.
Additional hints to layouts provided are added to be consistent with other keyboards on market, that have same options in popups and many people find it wery comfortable to use.
Additional Extended layouts added for more flexibility in overall usage. Since it re-uses already exiting class and code, all work fine with no problems at all, and just add more options, for example ' or ъ as separate keys (refering to nowdays GBoard layout and Samsung Keyboard, with are popular)
Test release provided in my fork, you can download it and see al changes at one. Illustrations to changes awill be provided in below comment within few minutes.