Change flag behavior to introduce metric priority levels #117
Conversation
|
@roclark Just took a quick hack at what I thought might sit in "core" or "extended" categories. I welcome other thoughts! |
There was a problem hiding this comment.
I will take a deeper dive at this later today depending on what my schedule looks like, but I think this looks pretty good!
While looking at the testing page, something we might want to consider is testing core vs. enabled metrics. As in, run some tests and make sure we get all of the "enabled" metrics, but also make sure that when the "core" flag is set, we only get core metrics. It's not readily obvious to me what the best way would be, but there might be value... maybe.
README.md
Outdated
|
|
||
| All above flags default to the value "extended" when no argument is submitted by the user. | ||
|
|
||
| Example: ./lustre_exporter -collector.ost=disabled -collector.mdt=core -collector.mgs=extended |
There was a problem hiding this comment.
This might just be me, but I think it would be easier to read if the example is put in a code block.
"Example: ./lustre_exporter..."
README.md
Outdated
| Example: ./lustre_exporter -collector.ost=disabled -collector.mdt=core -collector.mgs=extended | ||
|
|
||
| The above example will result in a running instance of the Lustre Exporter with the following statuses: | ||
| collector.ost=disabled |
There was a problem hiding this comment.
This might need to be in a code block or a list since these wrap into the previous line in the README. I don't have a strong opinion for which one, so whatever you think would be best. See the README for an example.
There was a problem hiding this comment.
Ah, yes. That looks like doodoo.
Change flags from binary to string arguments, and introduce the concept of disabled, core, and extended. Signed-Off-By: Joe Handzik <joseph.t.handzik@hpe.com>
joehandzik
force-pushed
the
wip-augment-flags
branch
from
a9a1167 to
15e50cd
Compare
|
@roclark Fixed the two issues you identified. Agreed that we can expand testing to include more permutations of core vs extended, but also agree that the path to adding that is a bit complex. |
|
Fire away! |
Change flags from binary to string arguments, and introduce the concept of disabled, core, and extended.
Signed-Off-By: Joe Handzik joseph.t.handzik@hpe.com
Fixes issue #116.