✨ 新增好感度/金币设置和详细帮助 #1831
Merged
✨ 新增好感度/金币设置和详细帮助 #1831
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Here's the translation to Chinese: 审阅者指南 by Sourcery此拉取请求实现了详细帮助功能，并添加了好感度和金币设置。 详细帮助生成的序列图sequenceDiagram
actor User
participant Bot
participant HelpSystem
participant PluginSystem
User->>Bot: 发送详细帮助命令
Bot->>HelpSystem: 请求详细帮助
HelpSystem->>PluginSystem: 获取插件信息
PluginSystem-->>HelpSystem: 返回带命令的插件数据
HelpSystem->>HelpSystem: 生成详细帮助图像
HelpSystem-->>Bot: 返回帮助图像
Bot-->>User: 显示详细帮助图像
更新的插件模型类图classDiagram
class Item {
+str plugin_name
+list[str] commands
}
class PluginInfo {
+str id
+str name
+str module
+int admin_level
+bool ignore_prompt
+bool is_delete
+str parent
}
class Command {
+str command
+list[str] params
+str description
}
class PluginExtraData {
+str author
+str version
+list[Command] commands
+bool ignore_prompt
+list[Task] tasks
+str superuser_help
}
PluginExtraData -- Command
Item -- Command
文件级变更
提示和命令与 Sourcery 交互
自定义您的体验访问您的仪表板以：
获取帮助Original review guide in EnglishReviewer's Guide by SourceryThis pull request implements a detailed help feature and adds settings for favorability and gold. Sequence diagram for detailed help generationsequenceDiagram
actor User
participant Bot
participant HelpSystem
participant PluginSystem
User->>Bot: Send detailed help command
Bot->>HelpSystem: Request detailed help
HelpSystem->>PluginSystem: Get plugin information
PluginSystem-->>HelpSystem: Return plugin data with commands
HelpSystem->>HelpSystem: Generate detailed help image
HelpSystem-->>Bot: Return help image
Bot-->>User: Show detailed help image
Class diagram for updated plugin modelsclassDiagram
class Item {
+str plugin_name
+list[str] commands
}
class PluginInfo {
+str id
+str name
+str module
+int admin_level
+bool ignore_prompt
+bool is_delete
+str parent
}
class Command {
+str command
+list[str] params
+str description
}
class PluginExtraData {
+str author
+str version
+list[Command] commands
+bool ignore_prompt
+list[Task] tasks
+str superuser_help
}
PluginExtraData -- Command
Item -- Command
File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
![sourcery-ai[bot]](https://avatars.githubusercontent.com/in/48477?s=60&v=4){kind=small}
There was a problem hiding this comment.
嘿 @HibiKier - 我已经审查了你的更改，看起来非常棒！
以下是我在审查期间关注的内容
- 🟡 一般性问题：发现1个问题
- 🟢 安全性：一切看起来都很好
- 🟢 测试：一切看起来都很好
- 🟢 复杂度：一切看起来都很好
- 🟢 文档：一切看起来都很好
帮助我变得更有用！请在每条评论上点击 👍 或 👎，我将使用这些反馈来改进你的评论。
Original comment in English
Hey @HibiKier - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 1 issue found
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟢 Complexity: all looks good
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
| user_id=at_user.target, | ||
| defaults={"user_console": user_console, "platform": platform}, | ||
| ) | ||
| user.impression = Decimal(impression) |
There was a problem hiding this comment.
建议 (bug_risk)： 添加边界检查并处理小数精度
考虑为合理的印象值范围添加验证，并确保在将浮点数转换为 Decimal 时正确处理小数精度，以防止无效状态。
建议的实现：
async def _(session: Uninfo, arparma: Arparma, impression: float, at_user: At):
# 验证印象值边界
if not 0 <= impression <= 1000000:
raise ValueError("印象值必须在 0 到 1,000,000 之间"）
platform = PlatformUtils.get_platform(session)
user_console = await UserConsole.get_user(at_user.target, platform)
user, _ = await SignUser.get_or_create(
user_id=at_user.target,
defaults={"user_console": user_console, "platform": platform},
)
# 转换为带有 2 位小数精度的 Decimal
try:
decimal_impression = Decimal(str(round(impression, 2)))
user.impression = decimal_impression
await user.save(update_fields=["impression"]）
except (ValueError, DecimalException) as e:
raise ValueError(f"无效的印象值：{e}"）你需要：
- 如果尚未导入，从 decimal 模块导入 Decimal
- 从 decimal 模块导入 DecimalException
- 考虑在此函数周围添加错误处理，以根据应用程序的需求捕获和处理 ValueError
Original comment in English
suggestion (bug_risk): Add bounds checking and handle decimal precision
Consider adding validation for reasonable impression value bounds and ensure proper decimal precision handling when converting from float to Decimal to prevent invalid states.
Suggested implementation:
async def _(session: Uninfo, arparma: Arparma, impression: float, at_user: At):
# Validate impression bounds
if not 0 <= impression <= 1000000:
raise ValueError("Impression value must be between 0 and 1,000,000")
platform = PlatformUtils.get_platform(session)
user_console = await UserConsole.get_user(at_user.target, platform)
user, _ = await SignUser.get_or_create(
user_id=at_user.target,
defaults={"user_console": user_console, "platform": platform},
)
# Convert to Decimal with 2 decimal places precision
try:
decimal_impression = Decimal(str(round(impression, 2)))
user.impression = decimal_impression
await user.save(update_fields=["impression"])
except (ValueError, DecimalException) as e:
raise ValueError(f"Invalid impression value: {e}")You'll need to:
- Import Decimal from decimal module if not already imported
- Import DecimalException from decimal module
- Consider adding error handling around this function to catch and handle the ValueError appropriately based on your application's needs
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.