-
Notifications
You must be signed in to change notification settings - Fork 609
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
🐛 fix(plugin-store): 优先获取commit号在进行插件下载 #1853
🐛 fix(plugin-store): 优先获取commit号在进行插件下载 #1853
Conversation
Original review guide in EnglishReviewer's Guide by SourceryThis pull request modifies the plugin store to prioritize fetching the latest commit hash before downloading plugins. This ensures that the most up-to-date version of the plugin is always used. The changes include modifications to the plugin installation process, the addition of new API endpoints, and the addition of new tests. No diagrams generated as the changes look simple and do not need a visual representation. File-Level Changes
Tips and commandsInteracting with Sourcery
Customizing Your ExperienceAccess your dashboard to:
Getting Help
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
嘿 @AkashiCoin - 我已经查看了你的更改 - 这里有一些反馈:
总体评论:
- 看起来你添加了很多新的模拟 API 端点;考虑重构以减少重复。
- 考虑添加注释来解释为什么提交哈希被优先考虑。
以下是我在审查期间查看的内容
- 🟢 一般问题:一切看起来都很好
- 🟢 安全性:一切看起来都很好
- 🟢 测试:一切看起来都很好
- 🟡 复杂性:发现 1 个问题
- 🟢 文档:一切看起来都很好
帮助我更有用!请点击每个评论上的 👍 或 👎,我将使用反馈来改进你的评论。
Original comment in English
Hey @AkashiCoin - I've reviewed your changes - here's some feedback:
Overall Comments:
- It looks like you've added a lot of new mocked API endpoints; consider refactoring to reduce duplication.
- Consider adding a comment to explain why the commit hash is being prioritized.
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.
No description provided.