Skip to content

Commit

Permalink
add default splash screen for iOS to allow full screen #18
Browse files Browse the repository at this point in the history
  • Loading branch information
Watson1978 committed Mar 1, 2016
1 parent 472cb07 commit bde192c
Show file tree
Hide file tree
Showing 3 changed files with 0 additions and 0 deletions.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.

6 comments on commit bde192c

@lrz
Copy link
Member

@lrz lrz commented on bde192c Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We might want to omit these files when generating the Android app (right now, all files in resources will be added to iOS/Android).

Maybe we could do something like this?

  • When building for iOS: add files from resources/ios/**/*
  • When building for Android: add files from resources/android/**/*
  • Always add files from resources/* (except ios and android folders)

@Watson1978
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

When create cross platform games, we always need Default-XXX.png
If users want to deploy game to android platform only, they can just remove it. And it is low cast. Don't you think so?

@lrz
Copy link
Member

@lrz lrz commented on bde192c Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How can they remove the files from the Android app right now?

@Watson1978
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

$ rm -rf rm -rf resources/Default-*.png

@lrz
Copy link
Member

@lrz lrz commented on bde192c Mar 1, 2016

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

But then you lose the files for iOS :)

@Watson1978
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I saied "If users want to deploy game to android platform only, they can just remove it. And it is low cast. Don't you think so?"

Please # to comment.