fix: when using SET_INITIAL_DATE_IF_NULL in STJ only set MinValue if JSON value is null and runtime type is not nullable
#600
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f json value is not nullable i think, this was the initial intention behind the converters? and there's no older/existing test that fails, so I think it's fine that way note that this does _NOT_ change the behaviour of the newtonsoft converters!
hf-kklein
changed the title
SET_INITIAL_DATE_IF_NULL in STJ only set MinValue if json value is not nullableSET_INITIAL_DATE_IF_NULL in STJ only set MinValue if JSON value is null and runtime type is not nullable
JoschaMetze
approved these changes
Nov 20, 2024
hf-kklein
added a commit
that referenced
this pull request
Nov 20, 2024
…f JSON value is null and runtime type is not nullable (#600) fix: when using `SET_INITIAL_DATE_IF_NULL` in STJ only set MinValue if json value is not nullable i think, this was the initial intention behind the converters? and there's no older/existing test that fails, so I think it's fine that way note that this does _NOT_ change the behaviour of the newtonsoft converters! Co-authored-by: Konstantin <konstantin.klein+github@hochfrequenz.de>
hf-kklein
added a commit
that referenced
this pull request
Nov 20, 2024
…f JSON value is null and runtime type is not nullable (#600) (#602) fix: when using `SET_INITIAL_DATE_IF_NULL` in STJ only set MinValue if json value is not nullable i think, this was the initial intention behind the converters? and there's no older/existing test that fails, so I think it's fine that way note that this does _NOT_ change the behaviour of the newtonsoft converters! Co-authored-by: Konstantin <konstantin.klein+github@hochfrequenz.de>
# for free
to join this conversation on GitHub.
Already have an account?
# to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
i think, this was the initial intention behind the converters? and there's no older/existing test that fails, so I think it's fine that way
note that this does NOT change the behaviour of the newtonsoft converters!