Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

#

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Jump to bottom

Fix test bot default formula tests #16423

Closed
wants to merge 1 commit into from
Closed

Fix test bot default formula tests #16423

wants to merge 1 commit into from

Conversation

MikeMcQuaid
Copy link
Member

#16422 confirms that these are not actually running like they should be.

For now: just try to prove this is definitely broken.

@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 2, 2024
Merged
@Bo98
Copy link
Member

Bo98 commented Jan 2, 2024 •
edited
Loading

At least for #16422, a reasonable explanation is because https://github.com/Homebrew/homebrew-test-bot/blob/master/Formula/t/testbottest.rb doesn't actually have any dependencies. It has a requirement so we have that part covered but we should maybe have a 2nd testbottestdep formula that we depend on.

@MikeMcQuaid
Copy link
Member Author

It has a requirement so we have that part covered but we should maybe have a 2nd testbottestdep formula that we depend on.

Good idea 👍🏻. May also be worth adding more DSLs e.g. a resource etc. too.

@Bo98
Copy link
Member

Bo98 commented Jan 2, 2024

Yeah that seems good too.

@MikeMcQuaid
Fix test bot default formula tests
95b0eab 
#16422 confirms that these are not
actually running like they should be.
@Bo98
Copy link
Member

Bo98 commented Jan 3, 2024 •
edited
Loading

Looks like various ignore_failures in test-bot need to exclude the case where @test_default_formula is set.

@MikeMcQuaid
Copy link
Member Author

Looks like various ignore_failures in test-bot need to exclude the case where @test_default_formula is set.

@Bo98 Indeed.

MikeMcQuaid added a commit to Homebrew/homebrew-test-bot that referenced this pull request Jan 3, 2024
@MikeMcQuaid
Fix ignore_failures usage with --test-default-formula
4aeb0c8 
Previously we were ignoring a bunch of failures in these cases which
makes this CI check pretty useless (e.g. see
Homebrew/brew#16423).
@MikeMcQuaid MikeMcQuaid mentioned this pull request Jan 3, 2024
Merged
@MikeMcQuaid
Copy link
Member Author

Test default formula job now failing as expected (https://github.com/Homebrew/brew/actions/runs/7389949784/job/20166731156?pr=16423) by merge of Homebrew/homebrew-test-bot#996. Closing.

@MikeMcQuaid MikeMcQuaid closed this Jan 4, 2024
@MikeMcQuaid MikeMcQuaid deleted the fix_testbot_default_formula branch January 4, 2024 16:04
@Bo98
Copy link
Member

Bo98 commented Jan 4, 2024

Nice. Still will need to follow up with a depends_on case that would have covered my PR but it's good we have at least minimal coverage again.

@github-actions github-actions bot added the outdated PR was locked due to age label Mar 2, 2024
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 2, 2024
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Reviewers
No reviews
Assignees
No one assigned
Labels
outdated PR was locked due to age
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MikeMcQuaid @Bo98