-
-
Notifications
You must be signed in to change notification settings - Fork 10.9k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
Update docker to 17.03.1-ce #31573
Update docker to 17.03.1-ce #31573
Conversation
|
||
url 'https://download.docker.com/mac/stable/Docker.dmg' | ||
appcast 'https://github.com/docker/docker/releases.atom', | ||
checkpoint: '0a205963d52892578e7f26e1a4b71b1b6cdf2605d0c48bb98f2a86ebe1f478c6' | ||
appcast 'https://download.docker.com/mac/stable/appcast.xml', |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This appcast URL also seems to be point to github internally. So do we really want to change this ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The github.com appcast is for source releases. This appcast is what is used by the docker .app for auto updates. See this comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the informations. In that case the App download URL seems to be different. Seems to have build number in the URL
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes, all docker .dmgs are still available for download through the appcast url
. The build numbers I think are internal and don't match the public releases.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ocean riethmayer: (master)$ brew cask cleanup
==> Removing cached downloads
/Users/riethmayer/Library/Caches/Homebrew/Cask/docker--17.03.0-ce.dmg
==> This operation has freed approximately 110.0MB of disk space.
ocean riethmayer: (master)$ brew update
Already up-to-date.
ocean riethmayer: (master)$ brew cask install docker
==> Satisfying dependencies
complete
==> Downloading https://download.docker.com/mac/stable/Docker.dmg
######################################################################## 100.0%
==> Verifying checksum for Cask docker
==> Note: running "brew update" may fix sha256 checksum errors
Error: sha256 mismatch
Expected: ed670f3a456289ce887ce8ac54f47a5d17df26353beceb463dc09c4709973a3d
Actual: 403b167dff238f5cbdb5fb085a842b8c8e1d6812956873f47df875a01adb0200
File: /Users/riethmayer/Library/Caches/Homebrew/Cask/docker--17.03.0-ce.dmg
To retry an incomplete download, remove the file above.
Looks like the checksum is currently not working for 17.03.0-ce.dmg
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@riethmayer Since the download URL points to the latest version, it's expectable that there will be a sha256 mismatch on each new release. Since this is now merged, this should be fixed at the moment.
After making all changes to the cask:
brew cask audit --download {{cask_file}}
is error-free.brew cask style --fix {{cask_file}}
reports no offenses.