p4v 18.3-1719707: Add CLI-accessible commands to work with Git out of the box

[pete-woods]

• Wrapper script needed so that its embedded Qt can be found
  (i.e. just symlinking won't work, similar to kdiff3)

After making all changes to the cask:

• brew cask audit --download {{cask_file}} is error-free.
• brew cask style --fix {{cask_file}} reports no offenses.
• The commit message includes the cask’s name and version.
• The submission is for a stable version or documented exception.

[pete-woods]

Does anyone have time to have a look over this pull request? It should be pretty straightforward.

[vitorgalvao]

Thank you, but we don’t make CLI commands out of Contents/MacOS unless it’s specifically recommended upstream (is it?).

[pete-woods]

Well the "proper" script in resources for p4merge just segfaults.

[pete-woods]

https://community.perforce.com/s/article/2848

[pete-woods]

Not too helpful to just immediately close this pull request, when there are other things I can try.

[pete-woods]

I'm going to see if I can make the proper script not segfault.

[pete-woods]

I got the inspiration for this from https://github.com/Homebrew/homebrew-cask/blob/master/Casks/kdiff3.rb which does the same thing linking into Contents/MacOS, btw.

[pete-woods]

Though that, I guess importantly, includes a reference to #18809

[pete-woods]

Just reading the PR for that change, to see what the discussion was: #35967

[pete-woods]

Actually, I just read that p4 docs page fully, and found this quote:

An alternative to using shell script is to add an "alias" to the shell profile. For example, for the bash shell add the following line to the .bashrc file in the home directory:

alias p4merge='/Applications/p4merge.app/Contents/MacOS/p4merge

[pete-woods]

Does that make the shim script legit?

[vitorgalvao]

Not too helpful to just immediately close this pull request, when there are other things I can try.

I’m tired of typing this, but closing an issue does not mean the conversation is over, as evidenced by the fact you’re still able to make that comment. Closing does not mean locking or deleting, it means archiving.

In fact, I specifically invited you to reply when I asked (emphasis added):

unless it’s specifically recommended upstream (is it?).

The most common response when “there are other things to try” and we leave the issue open is silence. Nothing at all. It’s another lingering issue left in the way of trying to tackle them all. Closing is way more efficient. Had you said nothing, time saved. Since you did, no harm done. I can even reopen the issue!

I got the inspiration for this from https://github.com/Homebrew/homebrew-cask/blob/master/Casks/kdiff3.rb which does the same thing linking into Contents/MacOS, btw.

The majority of the times I point out a rule and someone else points out “but this other cask does it” ends in either “because that cask has this particularity” or “and that one is also wrong”.

Does that make the shim script legit?

Yes, but please edit and follow the same pattern as the others (adding the empty line and comment).

Finally, please don’t post so much in a row. This is a not a chat app, and it makes the issue more difficult to parse and fills my inbox.

[pete-woods]

Apologies for directionless complaining, it's not the most productive thing to do.

Firstly, I've tried to update the patch as you requested, though the style checker doesn't want me to put a blank line in, so I'm probably misinterpreting where you want it.

With regards to my earlier griping, I would only say that it's pretty disheartening to see the first thing in response to a patch you've worked on being "patch closed". I now understand that's your workflow for this repo, and will update my expectations accordingly.

I would, however, suggest that a bot to auto close stale tickets for you (even with a relatively short timeout) is a lot more welcoming, especially to first time contributors.

[vitorgalvao]

Apologies for directionless complaining, it's not the most productive thing to do.

Thank you for the words.

I would, however, suggest that a bot to auto close stale tickets for you

Noted. We do have one, but it only works for issues (i.e. not PRs).

[pete-woods]

Thanks for the merge! 👍