Skip to content

platformio 6.1.6 #121330

New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

Closed
wants to merge 1 commit into from
Closed

platformio 6.1.6 #121330

wants to merge 1 commit into from

Conversation

ivankravets
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you ensured that your commits follow the commit style guide?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install --build-from-source <formula>)? If this is a new formula, does it pass brew audit --new <formula>?

  • Added support for Python 3.11
  • Added a new name configuration option to customize a project name (pull #4498)
  • Made assets (templates, 99-platformio-udev.rules) part of Python's module (issue #4458)
  • Updated Clang-Tidy check tool to v15.0.5 with new diagnostics and bugfixes
  • Removed dependency on the "zeroconf" package and install it only when a user lists mDNS devices (issue with zeroconf's LGPL license)
  • Show the real error message instead of "Can not remove temporary directory" when "platformio.ini" configuration file is broken (issue #4480)
  • Fixed an issue with an incorrect test summary when a testcase name includes a colon (issue #4508)
  • Fixed an issue when extends did not override options in the right order (issue #4462)
  • Fixed an issue when pio pkg list and pio pkg uninstall commands fail if there are circular dependencies in the library.json manifests (issue #4475)

@ivankravets ivankravets mentioned this pull request Jan 23, 2023
6 tasks
@BrewTestBot BrewTestBot added the python Python use is a significant feature of the PR or issue label Jan 23, 2023
@chenrui333
Copy link
Member

#121331

@chenrui333 chenrui333 added the superseded PR was replaced by another PR label Jan 23, 2023
@chenrui333
Copy link
Member

@ivankravets why did this get closed?

@ivankravets
Copy link
Contributor Author

CI failed with "revision: 1". I don't know who added that line to the manifest file. I didn't add it.

@SMillerDev
Copy link
Member

It doesn't really matter who added it. It should be removed on version updates. Please push updates to your existing pull requests though, constantly recreating them is hard to keep track off for maintainers and quite frankly motivates me to just ignore this update until you manage to figure out how to keep it to one PR.

@chenrui333
Copy link
Member

➕ to what SMillerDev said.

You can also use brew bump --open-pr platformio, which would handle the revision for your next PR version bump. Thanks!

@ivankravets
Copy link
Contributor Author

Sorry, we don't release PlatormIO Core so often. Typically a few times per year.

What I noticed, the moderation team here changes often rules as well. The previous moderators asked me to recreate new PR even with small changes (extra spaces).

I always have problems with updating the PlatformIO formula. Maybe, we will ask you to remove it from the homebrew registry. Need to ask how many people used it. Mostly, developers use PlatormIO in pair with VSCode (above 3,000,000 developers, https://marketplace.visualstudio.com/items?itemName=platformio.platformio-ide), where PlatformIO is directly integrated into the extension.

Sorry again for the issues.

@SMillerDev
Copy link
Member

The previous moderators asked me to recreate new PR even with small changes (extra spaces).

Can you link that pull request because I doubt that.

Maybe, we will ask you to remove it from the homebrew registry.

I think the 1000 users in the last 30 days would be pretty disappointed so that'll be a no from me.

@ivankravets
Copy link
Contributor Author

I'll check the previous PR/releases and share them here.

Regarding the "1000 users in the last 30 days". Oh, I didn't know that so many of users use platformio via brew. So, let's keep it here.

Do you have any simple steps on how to generate platformio formula next time? I use the next:

  1. Create a clean Python virtual environment
  2. pip install homebrew-pypi-poet
  3. poet -f platformio
  4. Edit the existing platformio formula and merge changes manually. This is the place where "typos" happen.

@SMillerDev
Copy link
Member

brew bump --open-pr platformio should be all you need.

@ivankravets
Copy link
Contributor Author

Thanks, will try next time. Thanks again for your help!

@github-actions github-actions bot added the outdated PR was locked due to age label Feb 23, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 23, 2023
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
outdated PR was locked due to age python Python use is a significant feature of the PR or issue superseded PR was replaced by another PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants