-
-
Notifications
You must be signed in to change notification settings - Fork 12.6k
New issue
Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? # to your account
erlang 22.0 #39877
erlang 22.0 #39877
Conversation
Running
Running
|
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We have too many versioned erlang formulas in core, we need to remove some of the older ones (17 and 18).
@fxcoudert Updated code |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We need to determine whether riak
can be compiled with a more recent erlang version
@fxcoudert So it looks like we still need to keep the older versions of erlang based on the response from the riak people. If I add 17 back, should I add 18 as well? |
@fxcoudert Bumping this, how should we proceed? |
@tomciopp restore erlang 17, leave erlang 18 out, and we should be good |
@fxcoudert Done |
@tomciopp Can you bump this to OTP 22.0.1? It was released a day or two after to fix an important ssh issue: https://github.com/erlang/otp/releases/tag/OTP-22.0.1 erlang.org is just always a bit behind on minor release announcements |
@archseer Will update. |
@tomciopp Correct end of files please(https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/42314/version=high_sierra/testReport/)
|
Please squash your changes into three commits:
|
@fxcoudert Updated |
@fxcoudert bumping, can we merge? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your contribution to Homebrew! 🎉 🥇 Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!! |
Closes #39877. Signed-off-by: Izaak Beekman <zbeekman@gmail.com>
brew install --build-from-source <formula>
, where<formula>
is the name of the formula you're submitting?brew test <formula>
, where<formula>
is the name of the formula you're submitting?brew audit --strict <formula>
(after doingbrew install <formula>
)?