Skip to content
New issue

Have a question about this project? # for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “#”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? # to your account

erlang 22.0 #39877

Closed
wants to merge 3 commits into from
Closed

erlang 22.0 #39877

wants to merge 3 commits into from

Conversation

tomciopp
Copy link
Contributor

  • Have you followed the guidelines for contributing?
  • Have you checked that there aren't other open pull requests for the same formula update/change?
  • Have you built your formula locally with brew install --build-from-source <formula>, where <formula> is the name of the formula you're submitting?
  • Is your test running fine brew test <formula>, where <formula> is the name of the formula you're submitting?
  • Does your build pass brew audit --strict <formula> (after doing brew install <formula>)?

@tomciopp
Copy link
Contributor Author

Running brew test erlang returns the following error:

Error: Testing requires the latest version of erlang

Running brew audit --strict erlang returns the following error:

erlang:
* Formula has invalid versioned aliases:
  erlang@22
Error: 1 problem in 1 formula detected

@BrewTestBot
Copy link
Member

  • New formulae should not have a bottle do block

Aliases/erlang@21 Outdated Show resolved Hide resolved
Copy link
Member

@fxcoudert fxcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We have too many versioned erlang formulas in core, we need to remove some of the older ones (17 and 18).

@tomciopp
Copy link
Contributor Author

@fxcoudert Updated code

Copy link
Member

@fxcoudert fxcoudert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We need to determine whether riak can be compiled with a more recent erlang version

Formula/erlang@21.rb Outdated Show resolved Hide resolved
Formula/erlang@21.rb Outdated Show resolved Hide resolved
Formula/erlang@21.rb Show resolved Hide resolved
@tomciopp
Copy link
Contributor Author

@fxcoudert basho/riak#978

@tomciopp
Copy link
Contributor Author

@fxcoudert So it looks like we still need to keep the older versions of erlang based on the response from the riak people. If I add 17 back, should I add 18 as well?

@tomciopp
Copy link
Contributor Author

@fxcoudert Bumping this, how should we proceed?

@fxcoudert
Copy link
Member

@tomciopp restore erlang 17, leave erlang 18 out, and we should be good

@tomciopp
Copy link
Contributor Author

@fxcoudert Done

@archseer
Copy link

@tomciopp Can you bump this to OTP 22.0.1? It was released a day or two after to fix an important ssh issue: https://github.com/erlang/otp/releases/tag/OTP-22.0.1

erlang.org is just always a bit behind on minor release announcements

@tomciopp
Copy link
Contributor Author

@archseer Will update.

@plus3x
Copy link

plus3x commented May 21, 2019

@tomciopp Correct end of files please(https://jenkins.brew.sh/job/Homebrew%20Core%20Pull%20Requests/42314/version=high_sierra/testReport/)

erlang@17:
  * File should end with a newline

@fxcoudert
Copy link
Member

Please squash your changes into three commits:

  • erlang@18: delete
  • erlang 22.0.1 for the main formula update (and alias rename)
  • erlang@21 21.3.8 (new formula) for the new Erlang 21 formula

@tomciopp
Copy link
Contributor Author

@fxcoudert Updated

@tomciopp
Copy link
Contributor Author

@fxcoudert bumping, can we merge?

Copy link
Contributor

@zbeekman zbeekman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@zbeekman
Copy link
Contributor

Thanks for your contribution to Homebrew! 🎉 🥇

Without awesome contributors like you, it would be impossible to maintain Homebrew to the high level of quality users have come to expect. Thank you!!!!

@zbeekman zbeekman closed this May 23, 2019
zbeekman pushed a commit that referenced this pull request May 23, 2019
Closes #39877.

Signed-off-by: Izaak Beekman <zbeekman@gmail.com>
@lock lock bot added the outdated PR was locked due to age label Feb 15, 2020
@lock lock bot locked as resolved and limited conversation to collaborators Feb 15, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Labels
outdated PR was locked due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants