This repository has been archived by the owner on Jan 16, 2025. It is now read-only.
libmagic optional python bindings #17994
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
update to include building python bindings.
| @@ -9,13 +9,19 @@ class Libmagic < Formula | |||
| # Fixed upstream, should be in next release | |||
| # See http://bugs.gw.com/view.php?id=230 | |||
| def patches; DATA; end if MacOS.version < :lion | |||
|
|
|||
|
|
|||
There was a problem hiding this comment.
Watch your whitespace ;)
| @@ -10,12 +10,19 @@ class Libmagic < Formula | |||
| # See http://bugs.gw.com/view.php?id=230 | |||
| def patches; DATA; end if MacOS.version < :lion | |||
|
|
|||
| option "python", "Build Python bindings." | |||
There was a problem hiding this comment.
Call this option "with-python"
|
This seems to install the python stuff outside of its keg... /cc @samueljohn |
|
Please see "How to create a formula with nice Python bindings" section in https://github.com/mxcl/homebrew/wiki/Homebrew-and-Python. I hope to improve python support in the future, so that we can just use |
|
Or we wait just until #18588 is ready, so the |
ghost
assigned 
|
Included in 6e97ac1. With the new |
# for free
to subscribe to this conversation on GitHub.
Already have an account?
#.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
update to include building python bindings.