Updates weechat to 0.4.1 and fixes python support

[chadcatlett]

This patch upgrades weechat to 0.4.1 as well as fixing the cmake issues that lead to python errors as reported in #19300 and #19168.

Basically cmake is searching a cmake defined list of paths as well as the ones that weechat's cmake scripts define. This is leading to both system and brewed versions of python being picked up together.

[mistydemeo]

This won't accommodate non-/usr/local installs of Homebrew. Perhaps you can add in something like @@HOMEBREW_PREFIX@@ in the first entry that can be updated via inreplace in the install method?

[chadcatlett]

i'll update things appropriately

[mistydemeo]

The HOMEBREW_PREFIX string still needs to get expanded into the real string somewhere. Since the patch is in the __END__ block, string interpolation is not happening to it.

Can you add an inreplace 'FindPython.cmake', 'HOMEBREW_PREFIX', HOMEBREW_PREFIX line to the install method please?

[chadcatlett]

The line that adamv referenced in patches.rb#L137 does the substitution in the DATA/END block. I've verified it with install --interactive, the file is patched correctly.

[adamv]

Pulled, thanks!

[Julian]

This doesn't appear to fix anything for me Python-wise, I get the same compilation error. Is it working for someone?

[chadcatlett]

@Julian which compilation error are you referring to?

[Julian]

Sorry, my mistake. The ones which I thought were in one of those two tickets, where weechat was failing to link properly against homebrewed Python:

It looks like both of those tickets were referring to the stdlib issues though, apologies, this wasn't meant to address the linking issues then, is that someplace else that you saw, it was being discussed on IRC but maybe no one filed a ticket for it.

 Linking C shared module python.so
brew: superenv removed: -Wall -W -Werror-implicit-function-declaration
Undefined symbols for architecture x86_64:
  "_PyLong_Check", referenced from:
      _weechat_python_exec in weechat-python.o
  "_PyString_Check", referenced from:
      _weechat_python_dict_to_hashtable in weechat-python.o
      _weechat_python_exec in weechat-python.o
  "_PyUnicode_AsUTF8String", referenced from:
      _weechat_python_unicode_to_string in weechat-python.o
  "_PyUnicode_Check", referenced from:
      _weechat_python_exec in weechat-python.o
  "_PyUnicode_FromString", referenced from:
      _weechat_python_init_module_weechat in weechat-python.o
  "__Py_InitPyPyModule", referenced from:
      _weechat_python_init_module_weechat in weechat-python.o
      _weechat_python_load in weechat-python.o
ld: symbol(s) not found for architecture x86_64
clang: error: linker command failed with exit code 1 (use -v to see invocation)
make[2]: *** [src/plugins/python/python.so] Error 1
make[1]: *** [src/plugins/python/CMakeFiles/python.dir/all] Error 2
make[1]: *** Waiting for unfinished jobs....
Linking C shared module tcl.so
brew: superenv removed: -Wall -W -Werror-implicit-function-declaration
[ 65%] Built target tcl
make: *** [all] Error 2
==> Configuration
HOMEBREW_VERSION: 0.9.4
HEAD: b8e7f3cd15fe87be4f56bca4c633396037a7a670
CPU: dual-core 64-bit penryn
OS X: 10.8.3-x86_64
Xcode: 4.6.2
CLT: 4.6.0.0.1.1365549073
X11: 2.7.4 => /opt/X11
==> ENV
HOMEBREW_CC: clang
MAKEFLAGS: -j2
CMAKE_PREFIX_PATH: /usr/local
CMAKE_INCLUDE_PATH: /usr/include/libxml2:/System/Library/Frameworks/OpenGL.framework/Versions/Current/Headers/
CMAKE_LIBRARY_PATH: /System/Library/Frameworks/OpenGL.framework/Versions/Current/Libraries
PKG_CONFIG_PATH: /usr/local/opt/libtasn1/lib/pkgconfig:/usr/local/opt/p11-kit/lib/pkgconfig:/usr/local/opt/nettle/lib/pkgconfig:/usr/local/opt/gnutls/lib/pkgconfig
PKG_CONFIG_LIBDIR: /usr/lib/pkgconfig:/usr/local/Library/ENV/pkgconfig/10.8
ACLOCAL_PATH: /usr/local/share/aclocal
OBJC: cc
PATH: /usr/local/Library/ENV/4.3:/usr/local/opt/cmake/bin:/usr/local/opt/libtasn1/bin:/usr/local/opt/p11-kit/bin:/usr/local/opt/nettle/bin:/usr/local/opt/gnutls/bin:/usr/local/opt/libgpg-error/bin:/usr/local/opt/libgcrypt/bin:/usr/local/opt/aspell/bin:/usr/local/opt/python/bin:/usr/bin:/bin:/usr/sbin:/sbin

Error: weechat did not build