You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.
ViewPatients.tsx calls dispatch(searchPatients(debouncedSearchText)) and dispatch(fetchPatients()) in initial load. Both of these functions call PatientRepository.findAll().
So, patients list is fetched twice initially which is redundant.
To Reproduce
Steps to reproduce the behavior:
Navigate to: <host:port>/patients
Expected behavior
PatientRepository.findAll() called only once in initial load.
Hi @akshay-ap I reproduce the issue.
It doesn't make sense to have dispatch(fetchPatients()) after #1970
I think that in this case you can open a new PR and fix the issue 🥳 , otherwise I can do .
jackcmeyer
added
🐛bug
issue/pull request that documents/fixes a bug
good first issue
indicates an issue is good for a first time contributor
patients
issue/pull request that interacts with patients module
and removed
good first issue
indicates an issue is good for a first time contributor
labels
May 5, 2020
🐛 Bug Report
ViewPatients.tsx
callsdispatch(searchPatients(debouncedSearchText))
anddispatch(fetchPatients())
in initial load. Both of these functions callPatientRepository.findAll()
.So, patients list is fetched twice initially which is redundant.
To Reproduce
Steps to reproduce the behavior:
Navigate to:
<host:port>/patients
Expected behavior
PatientRepository.findAll()
called only once in initial load.Your Environment
This needs to be fixed with or before #2026.
The text was updated successfully, but these errors were encountered: