Skip to content
This repository has been archived by the owner on Jan 9, 2023. It is now read-only.

Successfully completed lab shows translation key instead of actual text #2295

Closed
jackcmeyer opened this issue Aug 13, 2020 · 6 comments · Fixed by #2385
Closed

Successfully completed lab shows translation key instead of actual text #2295

jackcmeyer opened this issue Aug 13, 2020 · 6 comments · Fixed by #2385
Assignees
@gaweki
Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module
Milestone
v2.0

Comments

@jackcmeyer
Copy link
Member

jackcmeyer commented Aug 13, 2020 •
edited
Loading

🐛 Bug Report

When completing a lab, it shows the translation key instead of the actual text.

To Reproduce

  1. create a lab
  2. complete the lab
  3. see the key says lab.successfullyCompleted

Expected behavior

The message should say Successfully completed ${type} for ${patient}
@jackcmeyer jackcmeyer added 🐛bug issue/pull request that documents/fixes a bug help wanted indicates that an issue is open for contributions good first issue indicates an issue is good for a first time contributor labs issue/pull request that interacts with labs module labels Aug 13, 2020
@jackcmeyer jackcmeyer added this to the v2.0 milestone Aug 13, 2020
@ArslanM786
Copy link

I will start working on this. Can I be assigned?

@morrme
Copy link
Contributor

morrme commented Aug 14, 2020

@ArslanM786 👍🏾

@morrme morrme added in progress indicates that issue/pull request is currently being worked on and removed help wanted indicates that an issue is open for contributions labels Aug 14, 2020
@morrme
Copy link
Contributor

morrme commented Sep 7, 2020

@ArslanM786 Just checking on this one as well...let us know if we may be of assistance!

gaweki added a commit to gaweki/hospitalrun-frontend that referenced this issue Sep 8, 2020
@gaweki
docs: Add successfullyCompleted translations
a155406 
Resolves HospitalRun#2295
@gaweki
Copy link
Contributor

gaweki commented Sep 8, 2020 •
edited
Loading

@morrme i fix this in here. But the PR mixed with other issue

@morrme
Copy link
Contributor

morrme commented Sep 9, 2020

@gaweki Please see @jackcmeyer 's note here: #2376 (review)

gaweki added a commit to gaweki/hospitalrun-frontend that referenced this issue Sep 9, 2020
@gaweki
fix: add successfullycompleted resolves HospitalRun#2295
2fc4ca4
@gaweki gaweki mentioned this issue Sep 9, 2020
Merged
@gaweki
Copy link
Contributor

gaweki commented Sep 9, 2020

@morrme would like to assign me?

@matteovivona matteovivona assigned gaweki and unassigned ArslanM786 Sep 9, 2020
# for free to subscribe to this conversation on GitHub. Already have an account? #.
Assignees

@gaweki gaweki

Labels
🐛bug issue/pull request that documents/fixes a bug good first issue indicates an issue is good for a first time contributor in progress indicates that issue/pull request is currently being worked on labs issue/pull request that interacts with labs module
Projects
None yet
Milestone
v2.0
Development

Successfully merging a pull request may close this issue.

fix(labs): updates successfully completed message gaweki/hospitalrun-frontend
4 participants
@jackcmeyer @gaweki @morrme @ArslanM786